Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planned_deprecations #254

Merged
merged 2 commits into from
Sep 5, 2024
Merged

planned_deprecations #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a66b148
planned_deprecations
JarbasAl Sep 5, 2024
2b9c930
tests
JarbasAl Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions ovos_plugin_manager/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,2 @@
from ovos_plugin_manager.utils import PluginTypes
from ovos_plugin_manager.plugin_entry import OpenVoiceOSPlugin
from ovos_utils.log import LOG


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)
12 changes: 3 additions & 9 deletions ovos_plugin_manager/audio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,10 @@
from ovos_config import Configuration
from ovos_utils.log import log_deprecation

log_deprecation("ovos_plugin_manager.audio has been deprecated on ovos-audio, "
"move to ovos_plugin_manager.media", "0.1.0")


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)
# TODO - restore this log in next release with updated version string
#log_deprecation("ovos_plugin_manager.audio has been deprecated on ovos-audio, "
# "move to ovos_plugin_manager.media", "1.0.0")
Comment on lines +8 to +10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Track restoration of deprecation log.

The deprecation log has been commented out with a note to restore it in the next release. It's crucial to track this task to ensure it's not forgotten.

Would you like me to open a GitHub issue to track the restoration of this deprecation log?



def find_audio_service_plugins() -> dict:
Expand Down
16 changes: 0 additions & 16 deletions ovos_plugin_manager/audio2ipa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,6 @@
from ovos_utils.log import LOG


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_audio2ipa_plugins() -> dict:
"""
Find all installed plugins
Expand Down
18 changes: 0 additions & 18 deletions ovos_plugin_manager/audio_transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,7 @@
from ovos_utils.log import LOG

from ovos_plugin_manager.templates.transformers import AudioTransformer, AudioLanguageDetector
from ovos_plugin_manager.utils import PluginTypes, PluginConfigTypes


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_audio_transformer_plugins() -> dict:
"""
Find all installed plugins
Expand Down
16 changes: 0 additions & 16 deletions ovos_plugin_manager/coreference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,6 @@
replace_coreferences


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_coref_plugins() -> dict:
"""
Find all installed plugins
Expand Down
17 changes: 0 additions & 17 deletions ovos_plugin_manager/g2p.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,6 @@
from ovos_plugin_manager.utils import normalize_lang, PluginTypes, PluginConfigTypes
from ovos_plugin_manager.templates.g2p import Grapheme2PhonemePlugin, PhonemeAlphabet
from ovos_utils.log import LOG
from ovos_config import Configuration


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_g2p_plugins() -> dict:
Expand Down
16 changes: 0 additions & 16 deletions ovos_plugin_manager/gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,6 @@
from ovos_utils.log import LOG


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_gui_plugins() -> dict:
"""
Find all installed plugins
Expand Down
16 changes: 0 additions & 16 deletions ovos_plugin_manager/keywords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,6 @@
from ovos_plugin_manager.templates.keywords import KeywordExtractor


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_keyword_extract_plugins() -> dict:
"""
Find all installed plugins
Expand Down
16 changes: 0 additions & 16 deletions ovos_plugin_manager/language.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,6 @@
from ovos_plugin_manager.utils import PluginTypes, PluginConfigTypes


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_tx_plugins() -> dict:
"""
Find all installed plugins
Expand Down
17 changes: 0 additions & 17 deletions ovos_plugin_manager/metadata_transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,6 @@
from ovos_plugin_manager.utils import normalize_lang, PluginTypes, \
PluginConfigTypes
from ovos_plugin_manager.templates.transformers import MetadataTransformer
from ovos_utils.log import LOG


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_metadata_transformer_plugins() -> dict:
Expand Down
16 changes: 0 additions & 16 deletions ovos_plugin_manager/microphone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,6 @@
from ovos_utils.log import LOG


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_microphone_plugins() -> dict:
"""
Find all installed plugins
Expand Down
16 changes: 0 additions & 16 deletions ovos_plugin_manager/phal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,6 @@
from ovos_utils.log import LOG


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_phal_plugins() -> dict:
"""
Find all installed plugins
Expand Down
16 changes: 0 additions & 16 deletions ovos_plugin_manager/postag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,6 @@
from ovos_plugin_manager.templates.postag import PosTagger


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_postag_plugins() -> dict:
"""
Find all installed plugins
Expand Down
15 changes: 0 additions & 15 deletions ovos_plugin_manager/segmentation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,6 @@
from ovos_plugin_manager.templates.segmentation import Segmenter


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_segmentation_plugins() -> dict:
"""
Expand Down
2 changes: 1 addition & 1 deletion ovos_plugin_manager/skills.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def get_default_skills_directory(conf: Optional[dict] = None) -> str:
if path_override:
log_deprecation("'directory_override' is deprecated!"
"add the new path to 'extra_directories' instead",
"0.1.0")
"1.0.0")
skills_folder = expanduser(path_override)
elif conf["skills"].get("extra_directories") and \
len(conf["skills"].get("extra_directories")) > 0:
Expand Down
15 changes: 0 additions & 15 deletions ovos_plugin_manager/solvers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,6 @@
from ovos_utils.log import LOG


def find_plugins(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import find_plugins
return find_plugins(*args, **kwargs)


def load_plugin(*args, **kwargs):
# TODO: Deprecate in 0.1.0
LOG.warning("This reference is deprecated. "
"Import from ovos_plugin_manager.utils directly")
from ovos_plugin_manager.utils import load_plugin
return load_plugin(*args, **kwargs)


def find_question_solver_plugins() -> dict:
"""
Expand Down
Loading
Loading