fix:handle unloaded namespaces

[JarbasAl]

happens every boot

Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]: 2024-09-18 19:45:11.325 - gui - ovos_gui_plugin_shell_companion:handle_remove_namespace:84 - INFO - Got Clear Namespace Event In Skill
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]: [E 240918 19:45:11 _base:342] exception calling callback for <Future at 0xffff8463a250 state=finished raised IndexError>
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:     Traceback (most recent call last):
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:       File "/usr/lib/python3.11/concurrent/futures/_base.py", line 340, in _invoke_callbacks
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:         callback(self)
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:       File "/home/ovos/.venv/lib/python3.11/site-packages/pyee/_executor.py", line 57, in _callback
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:         self.emit("error", exc)
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:       File "/home/ovos/.venv/lib/python3.11/site-packages/pyee/_base.py", line 118, in emit
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:         self._emit_handle_potential_error(event, args[0] if args else None)
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:       File "/home/ovos/.venv/lib/python3.11/site-packages/pyee/_base.py", line 88, in _emit_handle_potential_error
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:         raise error
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:       File "/usr/lib/python3.11/concurrent/futures/thread.py", line 58, in run
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:         result = self.fn(*self.args, **self.kwargs)
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:       File "/home/ovos/.venv/lib/python3.11/site-packages/ovos_gui/namespace.py", line 1014, in handle_namespace_global_back
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:         namespace_name = self.active_namespaces[0].skill_id
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:                          ~~~~~~~~~~~~~~~~~~~~~~^^^
Sep 18 19:45:11 OpenVoiceOS ovos-gui-websocket[793]:     IndexError: list index out of range

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling for scenarios with no active namespaces, preventing potential crashes and unexpected behavior.

• New Features

  • Introduced checks in key methods to enhance robustness and control flow under invalid conditions.

[coderabbitai]

Walkthrough

The changes introduce error handling in the _load_pages and handle_namespace_global_back methods of the Namespace class. These methods now include checks to log an error message and return early if there are no active namespaces, thereby preventing execution under invalid conditions. This modification enhances the control flow and robustness of the code by avoiding potential errors related to the absence of active namespaces.

Changes

Files	Change Summary
ovos_gui/namespace.py	Added error handling in _load_pages and handle_namespace_global_back methods to check for empty self.active_namespaces.

Poem

In the land of code where rabbits play,
A check was added to save the day.
No more errors when namespaces are few,
With logs to guide us, we know what to do!
Hopping through functions, so smooth and bright,
Our code is robust, oh what a delight! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

ovos_gui/namespace.py (1)

781-784: LGTM with a minor suggestion!

The added error handling looks good and prevents further execution when there are no active namespaces. The logic for loading pages in the active namespace is correct as well.

As a minor suggestion, consider catching a more specific exception like IndexError instead of the generic Exception for better error handling.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d2ff173 and 7f024a7.

Files selected for processing (1)

• ovos_gui/namespace.py (2 hunks)