Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor skills status check to resolve init bug #31

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

NeonDaniel
Copy link
Member

Closes #30

@NeonDaniel NeonDaniel marked this pull request as draft September 29, 2023 16:36
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@462cbd6). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #31   +/-   ##
======================================
  Coverage       ?   52.72%           
======================================
  Files          ?       11           
  Lines          ?     1011           
  Branches       ?        0           
======================================
  Hits           ?      533           
  Misses         ?      478           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldyfruit
Copy link
Member

Fixes issue #30

@JarbasAl JarbasAl added the bug Something isn't working label Sep 29, 2023
@JarbasAl JarbasAl marked this pull request as ready for review September 29, 2023 16:44
@JarbasAl JarbasAl merged commit 62e0332 into dev Sep 29, 2023
9 checks passed
@JarbasAl JarbasAl deleted the FIX_SkillsServiceStatusCheck branch September 29, 2023 16:44
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You must execute run_forever() before emitting messages
3 participants