trust semantic versioning #538
Conversation
closes #488
|
Warning Rate limit exceeded@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 1 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes involve updates to various dependency version constraints across multiple requirements files, enhancing compatibility and stability. New files for specific skill dependencies, such as audio and desktop skills, have been introduced. Existing files have been modified to include upper version limits and additional skills, ensuring a more structured approach to dependency management. The setup script has also been updated to include new audio skill requirements. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Requirements
participant Setup
Developer->>Requirements: Update version constraints
Requirements->>Setup: Include new dependencies
Setup->>Developer: Confirm updated setup
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- requirements/mycroft.txt (1 hunks)
- requirements/requirements.txt (1 hunks)
- requirements/skills-audio.txt (1 hunks)
- requirements/skills-desktop.txt (1 hunks)
- requirements/skills-essential.txt (1 hunks)
- requirements/skills-gui.txt (1 hunks)
- requirements/skills-internet.txt (1 hunks)
- requirements/skills-media.txt (1 hunks)
- setup.py (1 hunks)
Additional context used
LanguageTool
requirements/skills-media.txt
[uncategorized] ~3-~3: A comma might be missing here.
Context: ...m>=0.0.2,<1.0.0 skill-news>=0.0.4,<1.0.0 ovos-skill-pyradios>=0.1.0,<1.0.0 ovos-s...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
requirements/skills-audio.txt
[uncategorized] ~4-~4: A comma might be missing here.
Context: ...1.0.0 ovos-skill-dictation>=0.1.0,<1.0.0 ovos-skill-parrot>=0.0.1,<1.0.0 ovos-ski...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
requirements/mycroft.txt
[locale-violation] ~9-~9: “server” é um estrangeirismo. É preferível dizer “servidor”.
Context: ....0.0 # default plugins ovos-stt-plugin-server>=0.0.3, <1.0.0 ovos-tts-plugin-mimic>=0...(PT_BARBARISMS_REPLACE_SERVER)
[locale-violation] ~11-~11: “server” é um estrangeirismo. É preferível dizer “servidor”.
Context: ...in-mimic>=0.2.8, <1.0.0 ovos-tts-plugin-server>=0.0.2a6, <1.0.0 ovos-ww-plugin-pocket...(PT_BARBARISMS_REPLACE_SERVER)
[misspelling] ~18-
18: Você quis dizer “YouTube”?=0.0, >=0.0.1 ovos-ocp-m3u-plugi...
Context: ...n_common_play>=0.0.7, <1.0.0 # ovos-ocp-youtube-plugin(YOUTUBE)
Ruff
setup.py
73-73: SyntaxError: Expected an expression or a '}'
Additional comments not posted (50)
requirements/skills-gui.txt (1)
1-1: LGTM!The version constraint update for
ovos-skill-homescreenlooks good. It follows semantic versioning conventions by specifying a minimum version0.0.3and an upper limit<1.0.0before the next major version. This ensures compatibility and stability.requirements/skills-desktop.txt (1)
1-2: LGTM!The newly added dependency
ovos-skill-application-launcherwith the version constraint>=0.1.0,<1.0.0looks good. It clearly specifies the required package for skills to operate correctly in a Linux desktop environment.requirements/skills-media.txt (1)
1-6: LGTM!The newly added dependencies for skills that require audio playback plugins look good:
ovos-skill-somafm>=0.0.2,<1.0.0skill-news>=0.0.4,<1.0.0ovos-skill-pyradios>=0.1.0,<1.0.0ovos-skill-local-media>=0.2.0,<1.0.0ovos-skill-youtube-music>=0.1.1,<1.0.0The version constraints follow semantic versioning conventions by specifying minimum versions and upper limits before the next major versions. This ensures compatibility and stability.
Tools
LanguageTool
[uncategorized] ~3-~3: A comma might be missing here.
Context: ...m>=0.0.2,<1.0.0 skill-news>=0.0.4,<1.0.0 ovos-skill-pyradios>=0.1.0,<1.0.0 ovos-s...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
requirements/skills-audio.txt (7)
1-1: LGTM!The comment clearly describes the purpose of the file.
2-2: LGTM!The version constraint for the
ovos-skill-boot-finishedskill is well-defined and follows the semantic versioning format.
3-3: LGTM!The version constraint for the
ovos-skill-audio-recordingskill is well-defined and follows the semantic versioning format.
4-4: LGTM!The version constraint for the
ovos-skill-dictationskill is well-defined and follows the semantic versioning format.Tools
LanguageTool
[uncategorized] ~4-~4: A comma might be missing here.
Context: ...1.0.0 ovos-skill-dictation>=0.1.0,<1.0.0 ovos-skill-parrot>=0.0.1,<1.0.0 ovos-ski...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
5-5: LGTM!The version constraint for the
ovos-skill-parrotskill is well-defined and follows the semantic versioning format.
6-6: LGTM!The version constraint for the
ovos-skill-volumeskill is well-defined and follows the semantic versioning format.
7-7: LGTM!The version constraint for the
ovos-skill-naptimeskill is well-defined and follows the semantic versioning format.requirements/skills-essential.txt (9)
1-1: LGTM!The comment clearly describes the purpose of the file.
2-2: LGTM!The version constraint for the
ovos-skill-fallback-unknownskill is well-defined and follows the semantic versioning format.
3-3: LGTM!The version constraint for the
ovos-skill-alertsskill is well-defined and follows the semantic versioning format.
4-4: LGTM!The version constraint for the
ovos-skill-personalskill is well-defined and follows the semantic versioning format.
5-5: LGTM!The version constraint for the
ovos-skill-date-timeskill is well-defined and follows the semantic versioning format.
6-6: LGTM!The version constraint for the
ovos-skill-hello-worldskill is well-defined and follows the semantic versioning format.
7-7: LGTM!The version constraint for the
skill-wordnetskill is well-defined and follows the semantic versioning format.
8-8: LGTM!The version constraint for the
skill-randomnessskill is well-defined and follows the semantic versioning format.
9-9: LGTM!The version constraint for the
ovos-skill-spellingskill is well-defined and follows the semantic versioning format.requirements/skills-internet.txt (6)
1-1: LGTM!The comment clearly describes the purpose of the file.
2-2: LGTM!The version constraint for the
ovos-skill-weatherskill is well-defined and follows the semantic versioning format.
3-3: LGTM!The version constraint for the
skill-ddgskill is well-defined and follows the semantic versioning format.
4-4: LGTM!The version constraint for the
skill-wolfieskill is well-defined and follows the semantic versioning format.
5-5: LGTM!The version constraint for the
ovos-skill-wikipediaskill is well-defined and follows the semantic versioning format.
6-6: LGTM!The version constraint for the
skill-ovos-fallback-chatgptskill is well-defined and follows the semantic versioning format.requirements/requirements.txt (9)
10-10: The past review comment is no longer applicable as the suggested changes have already been incorporated.
9-9: LGTM!The version constraint update for
ovos-utilsis approved.
10-10: LGTM!The version constraint update for
ovos_bus_clientis approved.
11-11: LGTM!The version constraint update for
ovos-plugin-manageris approved.
12-12: LGTM!The version constraint update for
ovos-configis approved.
13-13: LGTM!The version constraint update for
ovos-lingua-francais approved.
14-14: LGTM!The version constraint update for
ovos-backend-clientis approved.
15-15: LGTM!The version constraint update for
ovos-workshopis approved.
17-17: LGTM!The version constraint update for
ovos-utterance-normalizeris approved.requirements/mycroft.txt (15)
2-2: Approved version constraint update forovos_PHAL.The update broadens the version range to include all versions before 1.0.0, starting from 0.0.5, aligning with the PR objectives.
3-3: Approved version constraint update forovos-audio.The update allows for all versions up to 1.0.0, starting from 0.0.2, aligning with the PR objectives.
4-4: Approved version constraint update forovos-listener.The update allows for all versions up to 1.0.0, starting from 0.0.3, aligning with the PR objectives.
5-5: Approved version constraint update forovos-gui.The update sets a new minimum version at 0.1.0 and allows for all versions up to 1.0.0, aligning with the PR objectives.
6-6: Approved version constraint update forovos-messagebus.The update specifies a minimum version at 0.0.1 and allows for all versions up to 1.0.0, aligning with the PR objectives.
9-9: Approved version constraint update forovos-stt-plugin-server.The update allows for all versions up to 1.0.0, aligning with the PR objectives.
Note: A static analysis tool suggested translating "server" to "servidor" for Portuguese. However, this is part of the package name and should not be changed.
Tools
LanguageTool
[locale-violation] ~9-~9: “server” é um estrangeirismo. É preferível dizer “servidor”.
Context: ....0.0 # default plugins ovos-stt-plugin-server>=0.0.3, <1.0.0 ovos-tts-plugin-mimic>=0...(PT_BARBARISMS_REPLACE_SERVER)
10-10: Approved version constraint update forovos-tts-plugin-mimic.The update allows for all versions up to 1.0.0, aligning with the PR objectives.
11-11: Approved version constraint update forovos-tts-plugin-server.The update allows for all versions up to 1.0.0, aligning with the PR objectives.
Note: A static analysis tool suggested translating "server" to "servidor" for Portuguese. However, this is part of the package name and should not be changed.
Tools
LanguageTool
[locale-violation] ~11-~11: “server” é um estrangeirismo. É preferível dizer “servidor”.
Context: ...in-mimic>=0.2.8, <1.0.0 ovos-tts-plugin-server>=0.0.2a6, <1.0.0 ovos-ww-plugin-pocket...(PT_BARBARISMS_REPLACE_SERVER)
13-13: Approved version constraint update forovos-ww-plugin-pocketsphinx.The update allows for all versions up to 1.0.0, aligning with the PR objectives.
14-14: Approved version constraint update forovos-ww-plugin-precise.The update allows for all versions up to 1.0.0, aligning with the PR objectives.
15-15: Approved version constraint update forovos-vad-plugin-webrtcvad.The update allows for all versions up to 1.0.0, aligning with the PR objectives.
17-17: Approved version constraint update forovos_plugin_common_play.The update sets a new minimum version at 0.0.7 and allows for all versions up to 1.0.0, aligning with the PR objectives.
19-19: Approved version constraint update forovos-ocp-m3u-plugin.The update allows for all versions up to 1.0.0, aligning with the PR objectives.
20-20: Approved version constraint update forovos-ocp-rss-plugin.The update allows for all versions up to 1.0.0, aligning with the PR objectives.
22-22: Approved version constraint update forovos-ocp-news-plugin.The update allows for all versions up to 1.0.0, aligning with the PR objectives.
setup.py (1)
74-74: Approved addition of'skills-audio'in theextras_requiredictionary.The addition of
'skills-audio'enhances the setup process by including additional dependencies necessary for audio skills, aligning with the PR objectives.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #538 +/- ##
==========================================
- Coverage 75.37% 75.29% -0.08%
==========================================
Files 15 15
Lines 3086 3089 +3
==========================================
Hits 2326 2326
- Misses 760 763 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
all dependencies should adopt new automations so we can benefit from semver in our requirements.txt before this PR is merged
if we trust semver, next breaking release of any dependency will be
1.0.0semver adoption tracking:
core dependencies:
core services
skills:
phal:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores