Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:microphone default #155

Merged
merged 2 commits into from
Sep 15, 2024
Merged

fix:microphone default #155

merged 2 commits into from
Sep 15, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 15, 2024

go back to using alsa by default as that change was a semi-breaking change #153

now that OPM supports plugin fallbacks it isnt an issue if its missing as it will just continue to sounddevice

we can revisit once we have proper mac/windows support

Summary by CodeRabbit

  • New Features
    • Updated microphone settings to improve audio input handling.
    • Default microphone module changed to enhance compatibility with ALSA.
  • Bug Fixes
    • Adjusted fallback modules to ensure better performance and reliability.

go back to using alsa by default as that  change was a semi-breaking change

now that OPM supports plugin fallbacks it isnt an issue if its missing as it will just continue to sounddevice

we can revisit once we have proper mac/windows support
@github-actions github-actions bot added the fix label Sep 15, 2024
Copy link
Contributor

coderabbitai bot commented Sep 15, 2024

Walkthrough

The changes involve updating the microphone configuration in the mycroft.conf file. The default microphone module has been changed from ovos-microphone-plugin-sounddevice to ovos-microphone-plugin-alsa. Corresponding fallback modules have also been adjusted: ovos-microphone-plugin-alsa now falls back to ovos-microphone-plugin-sounddevice, while ovos-microphone-plugin-sounddevice falls back to ovos-microphone-plugin-pyaudio. This reconfiguration may affect audio input handling.

Changes

Files Change Summary
ovos_config/mycroft.conf - Default microphone module changed to ovos-microphone-plugin-alsa.
- Fallback for ovos-microphone-plugin-alsa updated to ovos-microphone-plugin-sounddevice.
- Fallback for ovos-microphone-plugin-sounddevice updated to ovos-microphone-plugin-pyaudio.

Possibly related PRs

  • feat:fallback_plugins #153: This PR also modifies the mycroft.conf file to enhance the microphone configuration with fallback mechanisms, directly relating to the changes made in the main PR.

Poem

🐇 In the land where bunnies play,
A new sound plugin leads the way.
From sounddevice to ALSA we hop,
With fallbacks ready, we won't stop!
Hooray for clearer chats, oh what a day!
Let’s celebrate in our own bunny way! 🎉


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5d0dbf1 and c1db725.

Files selected for processing (1)
  • ovos_config/mycroft.conf (1 hunks)
Additional comments not posted (1)
ovos_config/mycroft.conf (1)

491-493: LGTM!

The changes look good and align with the PR objective of reverting the default microphone setting back to using ALSA. The updated fallback modules ensure proper handling in case ALSA is not available.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added fix and removed fix labels Sep 15, 2024
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@5d0dbf1). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #155   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      10           
  Lines          ?     791           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     791           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JarbasAl added a commit to OpenVoiceOS/ovos-dinkum-listener that referenced this pull request Sep 15, 2024
ensure we continue preferring alsa plugin over sounddevice

OpenVoiceOS/ovos-config#155
@github-actions github-actions bot added fix and removed fix labels Sep 15, 2024
@JarbasAl JarbasAl merged commit 0bbec90 into dev Sep 15, 2024
10 checks passed
@JarbasAl JarbasAl deleted the fixmicrophone-default branch September 15, 2024 22:34
JarbasAl added a commit to OpenVoiceOS/ovos-dinkum-listener that referenced this pull request Sep 15, 2024
ensure we continue preferring alsa plugin over sounddevice

OpenVoiceOS/ovos-config#155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant