refactor/get_response_v2_converse_session #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #68 +/- ##
==========================================
- Coverage 58.17% 57.67% -0.50%
==========================================
Files 34 34
Lines 3266 3301 +35
==========================================
+ Hits 1900 1904 +4
- Misses 1366 1397 +31
☔ View full report in Codecov by Sentry. |
NeonDaniel
reviewed
Apr 20, 2023
|
get_response tests from neon-utils might be applicable here https://github.com/NeonGeckoCom/neon-utils/blob/dev/tests/neon_skill_tests.py#L318-L806 |
This was referenced Apr 20, 2023
NeonDaniel
reviewed
Jul 11, 2023
64 tasks
JarbasAl
force-pushed
the
refactor/get_response_v2_converse_session
branch
from
24a6bf4
to
fb15069
Compare
JarbasAl
force-pushed
the
refactor/get_response_v2_converse_session
branch
from
7b73c8b
to
d8a439d
Compare
make get_response event based companion PR to ovos-core/pull/160 handle min alpha version of 0.0.8 move to proper base class make it safe for multiple simultaneous sessions
JarbasAl
force-pushed
the
refactor/get_response_v2_converse_session
branch
from
d8a439d
to
c2e1cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make get_response event based
companion PR to OpenVoiceOS/ovos-core#160