Add military menu control script #348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hop311
force-pushed
the
military-menu
branch
8 times, most recently
from
01f366c to
d5e626b
Compare
Hop311
force-pushed
the
military-menu
branch
2 times, most recently
from
252307c to
ba92c0e
Compare
wvpm
reviewed
Jan 29, 2025
wvpm
reviewed
Jan 29, 2025
wvpm
reviewed
Jan 29, 2025
| static const StringName morale_localisation_key = "PRESTIGE_MORALE_BONUS"; | ||
| static const StringName organisation_localisation_key = "PRESTIGE_MAX_ORG_BONUS"; | ||
|
|
||
| // Morale and organisation bonuses are always green with a + sign, matching the base game's behaviour |
There was a problem hiding this comment.
When negative they shouldn't be green.
Also can't you reuse the code to format modifier effects here?
wvpm
reviewed
Jan 29, 2025
|
|
||
| if constexpr (Branch == LAND) { | ||
| // TODO - calculate (max) men and morale properly in ArmyInstance and RegimentInstances and set here | ||
| unit_group_dict[military_info_unit_group_men_count_key] = static_cast<uint64_t>(unit_group.get_unit_count() * 3000); |
There was a problem hiding this comment.
What are the 3000's doing here?
This should not be hardcoded.
wvpm
reviewed
Jan 29, 2025
| static const StringName digin_localisation_key = "MILITARY_DIGIN_TOOLTIP"; | ||
| static const String moving_days_replace_key = "$DAYS$"; | ||
|
|
||
| int64_t days_spent_digging_in = 4; |
There was a problem hiding this comment.
Again, this should not be hardcoded.
There was a problem hiding this comment.
These are examples so reviewers can see that the UI side works, we don't yet have the SIM side data but I thought better to have something rather than leaving it completely unimplemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.