-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document state merging #306
Open
zaaarf
wants to merge
1
commit into
master
Choose a base branch
from
docs/state-merging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# State merging | ||
In the game, it may happen that two different countries own provinces that are part of a same state. Suppose a situation where a country acquires the remainder of a state it already owned. What happens to the buildings? | ||
|
||
## Ports | ||
The port rules are straightforward. The highest-level port is retained, and the rest are deleted. | ||
|
||
## Factories | ||
Factory logic is quite complicated. If there are two factories of the same type in the states to be merged, the following rules are applied in order: | ||
|
||
- If the factory in the state that was already owned is subsidized, it takes priority, regardless of level. | ||
- The factory with the highest level takes precedence. | ||
- The factory whom the country already owned is chosen, if it comes to a stalemate. | ||
|
||
The subsidization and hire priorities seem to be retained in factories that the country already owned, and discarded in factories that are acquired. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried, the existing factory always stays regardless of subsidies, hiring priority or level.