Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mod command line option #192

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Added mod command line option #192

merged 1 commit into from
Jan 15, 2024

Conversation

Hop311
Copy link
Contributor

@Hop311 Hop311 commented Jan 14, 2024

  • Added TYPE_PACKED_STRING_ARRAY command line option type, which is basically just a string option that can be used multiple times without overwriting.
  • Added --mod or -m option, which can be used multiple times, each time adding a mod's name (not including the /mod/ part of its path). Mods are loaded in reverse order, so the last mod added will have the highest priority when Dataloader looks up files.
  • Updates the SIM submodule to the registry-template-fun branch because that removes a "dataloader/NodeTools.hpp" include which was breaking the Github Action builds.

@Hop311 Hop311 marked this pull request as ready for review January 14, 2024 00:34
BrickPi
BrickPi previously approved these changes Jan 14, 2024
Copy link
Contributor

@BrickPi BrickPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested, code lgtm, good stuff :)

@Spartan322 Spartan322 added the enhancement New feature or request label Jan 14, 2024
@Hop311 Hop311 merged commit 92267a0 into master Jan 15, 2024
16 checks passed
@Hop311 Hop311 deleted the mod-paths branch January 15, 2024 00:24
@Hop311 Hop311 restored the mod-paths branch April 10, 2024 18:49
@Hop311 Hop311 deleted the mod-paths branch April 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants