Add constant GameMenuScene preload to GameStart.gd #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type hints to GameStart.gd constants Seperate section_name and setting_name from Nodes group in inspector Prefer callable's called_deferred to string caller in GameStart.gd Change `GameStart._initialize_game` to use change_scene_to_packed and GameMenuScene constant to change scene instead
Spartan322
force-pushed
the
improve/game-start-script
branch
from
0b6dfdd to
f945470
Compare
Hop311
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hints to GameStart.gd constants
Seperate section_name and setting_name from Nodes group in inspector
Prefer callable's called_deferred to string caller in GameStart.gd
Change
GameStart._initialize_gameto use change_scene_to_packed and GameMenuScene constant to change scene insteadThis seems to result in a quicker transition from loading screen to main menu.