Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More error checking #1802

Merged
merged 1 commit into from
Apr 21, 2021
Merged

More error checking #1802

merged 1 commit into from
Apr 21, 2021

Conversation

Martii
Copy link
Member

@Martii Martii commented Apr 21, 2021

Applies to #1705 #37 and post #1799

Ref(s):

* Transform GH 401 to 503 .  Mentioned at https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/ and encountered with newer migrated dep.
* Spec for authorization shows uppercasing... so new dep has it with incorrect casing I believe... may not matter on their server but consistancy here. Reverting.
* Add a few more important comments

Applies to OpenUserJS#1705 OpenUserJS#37 and post OpenUserJS#1799

Ref(s):
* https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.8
* https://developer.mozilla.org/docs/Web/HTTP/Authentication
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. REMOTE Remote system or service. labels Apr 21, 2021
@Martii Martii merged commit 67959c3 into OpenUserJS:master Apr 21, 2021
@Martii Martii deleted the Issue-1705post1799 branch April 21, 2021 20:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. REMOTE Remote system or service.
Development

Successfully merging this pull request may close these issues.

1 participant