Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash a deprecation in our Code base #1573

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

Martii
Copy link
Member

@Martii Martii commented Jan 16, 2019

  • Utilize this method for mongodb native... async/await with hasNext()/next() tested and can also work but part of ES6+

NOTE:

  • Code looks more uniform with this method e.g. always wondered why there wasn't a final aCallback

Ref:

Applies to #1516

* Utilize this method for mongodb native... `async`/`await` with `hasNext()`/`next()` tested and can also work but part of ES6+

NOTE:
* Code looks more uniform with this method e.g. always wondered why there wasn't a final `aCallback`

Ref:
* https://stackoverflow.com/questions/25507866/how-can-i-use-a-cursor-foreach-in-mongodb-using-node-js#answer-25508173

Applies to OpenUserJS#1516
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jan 16, 2019
@Martii Martii merged commit 4250e25 into OpenUserJS:master Jan 16, 2019
@Martii Martii deleted the Issue-1516sessionDeprecationFix branch January 16, 2019 23:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Development

Successfully merging this pull request may close these issues.

1 participant