Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behaviour for GitLab reporter on issue filtering #1129

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

alessandrozago
Copy link
Contributor

This pull request is related to the issue #1127 .
Updated code and changelog.

@alessandrozago alessandrozago marked this pull request as draft January 10, 2025 13:24
@alessandrozago
Copy link
Contributor Author

Hi @Ndpnt , I see that the changelog validation is failing with this message 'Error: Missing funder in the "Unreleased" section' (the validate_declarations error seems to be a one time exception).
I put the contribution acknowledgment line in the Changelog, but the error persists. Would you be able to verify what the issue is? Is it maybe just the point at the end of the line?
I did not find the correct checks it does from the other OTA projects/repositories.
Thank you

@Ndpnt
Copy link
Member

Ndpnt commented Jan 21, 2025

Hi @alessandrozago,
Yes, the changelog validation error is indeed due to the missing period at the end of the acknowledgment line. Adding the period should resolve it.
Regarding the validate_declarations error, it should be fixed by rebasing your branch with the latest changes from the main branch, as the fix has already been integrated there.

@alessandrozago
Copy link
Contributor Author

Hi, thank you for your feedback. I updated the pull request rebasing from the current main branch.
I also created a unique commit for the latest changes on the changelog, in order to have a clean history.
If there's any issue with this, I could also recreate the Pull request from scratch.

Thank you

@alessandrozago alessandrozago marked this pull request as ready for review January 22, 2025 09:42
CHANGELOG.md Outdated
@@ -2,6 +2,13 @@

All changes that impact users of this module are documented in this file, in the [Common Changelog](https://common-changelog.org) format with some additional specifications defined in the CONTRIBUTING file. This codebase adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased [minor]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this changeset corrects an unintended behavior in the software without introducing new features or breaking compatibility, it is considered as a patch in SemVer

Suggested change
## Unreleased [minor]
## Unreleased [patch]

Copy link
Member

@Ndpnt Ndpnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update changelog with proper release type

@Ndpnt Ndpnt merged commit 2c3aaf0 into OpenTermsArchive:main Jan 22, 2025
8 checks passed
@Ndpnt
Copy link
Member

Ndpnt commented Jan 22, 2025

Thanks for your contribution @alessandrozago 🙏 !

@alessandrozago
Copy link
Contributor Author

Hi @Ndpnt , sorry but I noticed that in my commits it also included a temporary directory "data (copy)" with 2 empty directories. Please let us know if we need to modify anything to clean this up, if I should made a pull request to remove it, or if you can change directly the history.

@Ndpnt
Copy link
Member

Ndpnt commented Jan 22, 2025

Hi @Ndpnt , sorry but I noticed that in my commits it also included a temporary directory "data (copy)" with 2 empty directories. Please let us know if we need to modify anything to clean this up, if I should made a pull request to remove it, or if you can change directly the history.

Thank you for flagging this! It was also my responsibility to catch this during the review. That said, it would indeed be great if you could provide a pull request 👍

@alessandrozago
Copy link
Contributor Author

alessandrozago commented Jan 22, 2025

Thank you for flagging this! It was also my responsibility to catch this during the review. That said, it would indeed be great if you could provide a pull request 👍

Sure. Should I just update this one or should I create a new Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants