-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect behaviour for GitLab reporter on issue filtering #1129
Conversation
Hi @Ndpnt , I see that the changelog validation is failing with this message 'Error: Missing funder in the "Unreleased" section' (the validate_declarations error seems to be a one time exception). |
Hi @alessandrozago, |
fix getIssue behaviour with the "state" parameter
Hi, thank you for your feedback. I updated the pull request rebasing from the current main branch. Thank you |
CHANGELOG.md
Outdated
@@ -2,6 +2,13 @@ | |||
|
|||
All changes that impact users of this module are documented in this file, in the [Common Changelog](https://common-changelog.org) format with some additional specifications defined in the CONTRIBUTING file. This codebase adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
## Unreleased [minor] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this changeset corrects an unintended behavior in the software without introducing new features or breaking compatibility, it is considered as a patch in SemVer
## Unreleased [minor] | |
## Unreleased [patch] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update changelog with proper release type
Thanks for your contribution @alessandrozago 🙏 ! |
Hi @Ndpnt , sorry but I noticed that in my commits it also included a temporary directory "data (copy)" with 2 empty directories. Please let us know if we need to modify anything to clean this up, if I should made a pull request to remove it, or if you can change directly the history. |
Thank you for flagging this! It was also my responsibility to catch this during the review. That said, it would indeed be great if you could provide a pull request 👍 |
Sure. Should I just update this one or should I create a new Pull Request? |
This pull request is related to the issue #1127 .
Updated code and changelog.