Enable the deployment of the Engine and the Federated API applications on a single server #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementbiron
approved these changes
Apr 11, 2024
README.md
Outdated
|
|
||
| | Variable | Description | Default value | Required | | ||
| | --- | --- | --- | --- | | ||
| | `ota_reverse_proxy_engine_path` | Path where the API of the engine will be available | `/collection-api` | - | |
There was a problem hiding this comment.
It's a bit confusing for me to say that the API of the engine will be available at /collection-api because the path does not bear the name of what it is claimed to be.
Suggested change
| | `ota_reverse_proxy_engine_path` | Path where the API of the engine will be available | `/collection-api` | - | | |
| | `ota_reverse_proxy_engine_path` | Path where the API of the collection will be available | `/collection-api` | - | |
If that feedback seem to you a relevant one, it will have to be applied to your other changes so that we no longer speak of the engine API but the collection API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.