Support federated API deployment #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiSG
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
This is… just… beautiful! 🥲 👏
I encounter some obstacles testing locally with Vagrant. The obstacles do not seem related to this changeset. I thus approve this PR after thorough review as it reads great, but I have not yet been able to test properly and hope to do so before merge.
roles/federated-api/tasks/main.yml
Outdated
|
|
||
| - name: Read the production config | ||
| shell: cat '/home/{{ ansible_user }}/{{ ota_federated_api_directory }}/config/production.json' | ||
| register: cat_config |
There was a problem hiding this comment.
Suggested change
| register: cat_config | |
| register: read_config |
Comment on lines
+28
to
+29
| - name: Install PM2 to latest version 5 | ||
| ansible.builtin.command: npm install -g pm2@5 --production=true |
There was a problem hiding this comment.
I'd argue this is not really
node/mainconceptually 😉
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Co-authored-by: Matti Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.