Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Energia Privacy Policy #880

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Conversation

OTA-Bot
Copy link
Collaborator

@OTA-Bot OTA-Bot commented Apr 29, 2023

🔎 Inspect this declaration update suggestion

Bots should take care of checking the formatting and the validity of the declaration. As a human reviewer, you should check:

  • Selectors are:
    • stable: as much as possible, the CSS selectors are meaningful and specific (e.g. .tos-content rather than .ab23 .cK_drop > div).
    • simple: the CSS selectors do not have unnecessary specificity (e.g. if there is an ID, do not add a class or a tag).
  • Generated version is:
    • relevant: it is not just a series of links, for example.
    • readable: it is complete and not mangled.
    • clean: it does not contain navigation links, unnecessary images, or extra content.

Thanks to your work and attention, Open Terms Archive will ensure that high quality data is available for all reusers, enabling them to do their part in shifting the balance of power towards end users and regulators instead of spending time collecting and cleaning documents 💪

Fixes #598


This update suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.

@Kissaki
Copy link
Contributor

Kissaki commented Apr 29, 2023

executeClientScripts so the email address hidden by Cloudflare shows up.

@Kissaki
Copy link
Contributor

Kissaki commented Apr 29, 2023

  • Because of a <br> headline 1.2 shows up as ****. 1.2 Contact Us in contribute tool due to faulty markdown code or rendering. Dunno if this is only an issue in the contribute tool or also the generated markdown.
  • Sections 5. Sharing your Information and 7.1 Right of Access have faulty markup - making use of ul li elements for paragraphs leading to shitty markdown/generated doc rendering. Better than nothing I guess. (Would this be where "filters" come in? They could adjust content?)

@MattiSG
Copy link
Member

MattiSG commented Sep 3, 2023

Thanks @Kissaki for this contribution, and for your attentive review of the generated version!

Both points are dependent of the underlying library used for Markdown conversion, turndown.

The first (<br>) is well known and has no fix.
The second is similar to OpenTermsArchive/engine#903.

There is not much we can do at this stage, except maybe OpenTermsArchive/engine#1019. It is still much better to track this way than to not track, so thanks for this update 🙂

MattiSG added a commit that referenced this pull request Sep 3, 2023
Update Energia Terms of Service <#879>
Update Energia Privacy Policy <#880>
@MattiSG MattiSG merged commit cf9c08d into main Sep 3, 2023
@MattiSG MattiSG deleted the update_energia_privacy_policy branch September 3, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Energia - Privacy Policy
4 participants