Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Waze URLs and selectors #1259

Merged
merged 7 commits into from
May 23, 2024

Conversation

afisher3578
Copy link
Contributor

Fix for issues #1135 and #1134

Copy link
Member

@clementbiron clementbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex :)

Your selectors do not delete blocks "Was this helpful?" and "Need more help?" which are not significants. I suggest to use the same selectors than for the Terms of Service and Privacy Policy that work.

declarations/Waze.json Show resolved Hide resolved
declarations/Waze.json Show resolved Hide resolved
@clementbiron clementbiron self-requested a review January 11, 2024 14:16
Copy link
Member

@clementbiron clementbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are formatting errors in the declaration file ;)

Testing localy with npx ota validate can help to avoid that kind of errors.

declarations/Waze.json Outdated Show resolved Hide resolved
declarations/Waze.json Outdated Show resolved Hide resolved
Copy link
Member

@clementbiron clementbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @afisher3578

The CI tests fail, so I can't accept your contribution in this state. But it's very easy to fix by checking that the files are properly formatted and linted.

@clementbiron clementbiron force-pushed the fix-waze-declarations branch from 9d0798c to e4f3d0b Compare April 18, 2024 08:18
@clementbiron clementbiron self-requested a review May 23, 2024 12:53
Copy link
Member

@clementbiron clementbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Alex.

I've just made the necessary changes to merge your contribution.

The CI tests failed because of a 404 error when fetching the Terms of Service. I take the responsibility to bypass branch protections because we've tested with @Ndpnt and it works both locally and on our experiments server.

@clementbiron clementbiron force-pushed the fix-waze-declarations branch from 5b48269 to 56d7f20 Compare May 23, 2024 14:05
@clementbiron clementbiron merged commit 764dce9 into OpenTermsArchive:main May 23, 2024
2 of 3 checks passed
@afisher3578 afisher3578 deleted the fix-waze-declarations branch November 20, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants