-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Waze URLs and selectors #1259
Update Waze URLs and selectors #1259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex :)
Your selectors do not delete blocks "Was this helpful?" and "Need more help?" which are not significants. I suggest to use the same selectors than for the Terms of Service and Privacy Policy that work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are formatting errors in the declaration file ;)
Testing localy with npx ota validate
can help to avoid that kind of errors.
4a97ce1
to
9d0798c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @afisher3578
The CI tests fail, so I can't accept your contribution in this state. But it's very easy to fix by checking that the files are properly formatted and linted.
9d0798c
to
e4f3d0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Alex.
I've just made the necessary changes to merge your contribution.
The CI tests failed because of a 404 error when fetching the Terms of Service. I take the responsibility to bypass branch protections because we've tested with @Ndpnt and it works both locally and on our experiments server.
Co-authored-by: Clément Biron <[email protected]>
Co-authored-by: Clément Biron <[email protected]>
5b48269
to
56d7f20
Compare
Fix for issues #1135 and #1134