Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter Customization Paragraph Input #360

Open
5 tasks
Tracked by #49
manishapriya94 opened this issue Oct 16, 2022 · 2 comments
Open
5 tasks
Tracked by #49

Letter Customization Paragraph Input #360

manishapriya94 opened this issue Oct 16, 2022 · 2 comments
Assignees
Labels
batch onboard campaign Review Letter Issues and PRs that involve the feature "Review Letter" user profile
Milestone

Comments

@manishapriya94
Copy link
Contributor

manishapriya94 commented Oct 16, 2022

Code This line in lobjs documentation can either be string or template_id, it can be changed to customized data, either by sending back customized part via submit api and concating in the backend or send it as a file param which is concated in the frontend, adding a input field though as part of this issue

Resources:

@manishapriya94
Copy link
Contributor Author

@DietBepis1 security risks we should consider?

@DietBepis1
Copy link
Collaborator

The biggest concern with users modifying our Lob templates is a cross-site scripting attack (XSS). Developers who are working on Amplify may have even noticed a linting error where the Lob template is injected:

xss linting

Some more info can be found here and here.

As for how to tackle the problem, we will need to have to have a way to sanitize a user's input. I am unsure if we can lean on Lob to do the sanitization, but that's one idea. Alternatively, before we re-render the template, we could write our own end-point that would parse it and return new html. A third idea would be to use some sort of rich text editor to create markdown and then transform it before sending to Lob.

Maybe none of those are good ideas, or there is a more elegant and obvious solution that I am overlooking. Let me know if you need help researching possibilities 😊.

@manishapriya94 manishapriya94 added this to the Onboarding milestone Jan 18, 2023
@rsensenig rsensenig added the Review Letter Issues and PRs that involve the feature "Review Letter" label Feb 16, 2023
@manishapriya94 manishapriya94 changed the title Letter Customization Input Letter Customization Paragraph Input Nov 8, 2023
@nancy-luu nancy-luu self-assigned this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch onboard campaign Review Letter Issues and PRs that involve the feature "Review Letter" user profile
Projects
Status: Overall Guiding Epics this Cohort
Development

No branches or pull requests

8 participants