Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing enter in the postal code form refreshes page #293

Closed
paramsiddharth opened this issue Aug 10, 2022 · 2 comments · Fixed by #396
Closed

Pressing enter in the postal code form refreshes page #293

paramsiddharth opened this issue Aug 10, 2022 · 2 comments · Fixed by #396
Assignees
Labels
good first issue Good for newcomers

Comments

@paramsiddharth
Copy link
Member

paramsiddharth commented Aug 10, 2022

Pressing enter in the postal code form refreshes page

image

After writing the postal code, it is user-tendency to press enter and expect the form to submit itself.

However, it doesn't happen right now, because the submit behaviour has only been attached to the button
and not the form. The submission behaviour of the form needs to be modified.

Refer

Possible Solution

  • The on-submit property of the v-form needs to recreate the on-click behaviour exhibited by the submit button.
  • For event e, e.preventDefault() needs to be called to prevent the default form submission behaviour i.e. Making a request to the current route with the data, which causes the page refresh.
@paramsiddharth
Copy link
Member Author

@tdo95 Hey Tee! While Sam works on the front-end part of #360, instead of waiting, we decided to assign you this simple front-end related issue to work on. :) Let me know if you have any trouble understanding what to do.

@tdo95
Copy link
Contributor

tdo95 commented Nov 8, 2022

Sure, I will start working on this (: @paramsiddharth

@tdo95 tdo95 moved this from Todo: fellow's pick of issue for the week to In Progress in Amplify Pairing Sign Up Nov 8, 2022
Repository owner moved this from In Progress: fellows finalize into PR in pair hour to Done in Amplify Pairing Sign Up Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants