-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark reports #2
Open
segsell
wants to merge
21
commits into
main
Choose a base branch
from
benchmark_reports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segsell
commented
Apr 21, 2023
src/tranquilo_dev/benchmark_report/task_create_index_for_benchmark_reports.py
Outdated
Show resolved
Hide resolved
Note: We can access the index page by clicking the left arrow. |
janosg
reviewed
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We should not re-create the plots but simply copy them into the directory where we need them. Something like I do for the slides in my current PR.
- For each report (trancebacks, ranks, convergence), there should be a public function with a similar interface as the
profile_plot
andconvergence_plot
in estimagic. I.e. those functions takeresults
andproblems
and internally callprocess_benchmark_results
. Since we don't have time pressure, those functions can be moved to estimagic right away. Those functions should also have default values for parameters that are in line with the plotting functions. That way we can probably also have a more concise plot_config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
pytask
andsphinx
to create an auto-generated webpage with dynamically generated toctree that contains the following information:To get back to the index page, simply click the left arrow at the bottom.