-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add pyOpenSci as the official mechanism for reviewing scientific python packages #61
Conversation
@lwasser when you have time, could you review this text please? |
It's on my list now Ivan! Thank you! |
content/programs/incubator/index.md
Outdated
By following pyOpenSci's robust evaluation framework, we aim to fortify the | ||
quality and impact of the Scientific Python projects emerging from the Open | ||
Science Labs Incubator program. We encourage all projects to actively engage in | ||
this evaluation process to facilitate their scientific rigor and reach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By following pyOpenSci's robust evaluation framework, we aim to fortify the | |
quality and impact of the Scientific Python projects emerging from the Open | |
Science Labs Incubator program. We encourage all projects to actively engage in | |
this evaluation process to facilitate their scientific rigor and reach. | |
By following pyOpenSci's robust evaluation framework, we aim to fortify the | |
quality and impact of the Scientific Python projects emerging from the Open | |
Science Labs Incubator program. We encourage all projects to actively engage in | |
this evaluation process to facilitate their scientific rigor and reach. |
i need to think about this a bit but i wonder if you want to use more relaxed language here?
something like
- the pyOpenSci review process will support improving the quality, usability and maintainability of your software.
- you can also benefit from visibility which your tool will gain once accepted into the pyOpenSci ecosystem and also community support..
something like that? the word evaluation is interesting but i'm not sure it's quite the right word here. and i am not sure about scientific rigor in the above text as we really are generally not focused on the scientific applications rather the software as it's used for science. Although if a tool has a very specific scientific algorithm we'd call in an expert for review. the language just seems a bit different from what we actually do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @lwasser , I hear you and that makes sense. I will update the text with your suggestions. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok @xmnlab i've left some comments. overall this looks good.
i want to make sure it's clear that just because we review and accept a package it could be out of scope for JOSS
and also i suggested some general adjustments to language to make sure it's inline with what we do. let me know if you have any questions! and thank you for pulling this together!
i'll work on some text on our side as well.
…c python packages
Co-authored-by: Leah Wasser <[email protected]>
Co-authored-by: Leah Wasser <[email protected]>
Co-authored-by: Leah Wasser <[email protected]>
Co-authored-by: Leah Wasser <[email protected]>
Thanks @lwasser ! |
This PR aims to add pyOpenSci as the official mechanism for review scientific Python packages.