Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pyOpenSci as the official mechanism for reviewing scientific python packages #61

Merged
merged 7 commits into from
Oct 22, 2023

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Oct 17, 2023

This PR aims to add pyOpenSci as the official mechanism for review scientific Python packages.

@xmnlab
Copy link
Member Author

xmnlab commented Oct 17, 2023

@lwasser when you have time, could you review this text please?

@lwasser
Copy link
Contributor

lwasser commented Oct 17, 2023

It's on my list now Ivan! Thank you!

Comment on lines 123 to 126
By following pyOpenSci's robust evaluation framework, we aim to fortify the
quality and impact of the Scientific Python projects emerging from the Open
Science Labs Incubator program. We encourage all projects to actively engage in
this evaluation process to facilitate their scientific rigor and reach.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By following pyOpenSci's robust evaluation framework, we aim to fortify the
quality and impact of the Scientific Python projects emerging from the Open
Science Labs Incubator program. We encourage all projects to actively engage in
this evaluation process to facilitate their scientific rigor and reach.
By following pyOpenSci's robust evaluation framework, we aim to fortify the
quality and impact of the Scientific Python projects emerging from the Open
Science Labs Incubator program. We encourage all projects to actively engage in
this evaluation process to facilitate their scientific rigor and reach.

i need to think about this a bit but i wonder if you want to use more relaxed language here?

something like

  • the pyOpenSci review process will support improving the quality, usability and maintainability of your software.
  • you can also benefit from visibility which your tool will gain once accepted into the pyOpenSci ecosystem and also community support..

something like that? the word evaluation is interesting but i'm not sure it's quite the right word here. and i am not sure about scientific rigor in the above text as we really are generally not focused on the scientific applications rather the software as it's used for science. Although if a tool has a very specific scientific algorithm we'd call in an expert for review. the language just seems a bit different from what we actually do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @lwasser , I hear you and that makes sense. I will update the text with your suggestions. thanks!

Copy link
Contributor

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @xmnlab i've left some comments. overall this looks good.

i want to make sure it's clear that just because we review and accept a package it could be out of scope for JOSS
and also i suggested some general adjustments to language to make sure it's inline with what we do. let me know if you have any questions! and thank you for pulling this together!

i'll work on some text on our side as well.

@xmnlab
Copy link
Member Author

xmnlab commented Oct 22, 2023

Thanks @lwasser !
I added all your suggestions! thank you so much, really appreciate that!

@xmnlab xmnlab merged commit fd3c0b4 into OpenScienceLabs:main Oct 22, 2023
@xmnlab xmnlab deleted the add-pyopensci branch October 22, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants