Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rr: Fix a buffer mgm bug during strict routing callbacks
While doing strict routing (e.g. the R-URI host is a local domain) and executing the module callbacks, the rr module would provide some bogus memory pointer as the result of the rr_api.get_route_param() function. Although opensips would not crash due to the dangling pointer residing in pkg memory, some callbacks would misbehave (e.g. uac_auth() would fail to adjust the outbound ACK CSeq, since it cannot locate the ";aci" Route header field parameter within the dangling pkg area). Related to #1613
- Loading branch information
ec89b78
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be backported to 2.4 branch as well? I'd love to test this fix against the nightly 2.4 packages.
ec89b78
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just backported it to
2.4
, @denislemire . Do let me know if you run into any more issues with your strict-routing scenario.