Add firewall command to Kickstart remediation #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we will add option for managing firewall rules during the installation: * `firewall enable service_name` - adds `service_name` to list in the `--service=` option in the `firewall` command in commands section in the kickstart * `firewall disable service_name` - adds `service_name` to list in the `--remove-service=` option in the `firewall` command in commands section in the kickstart Also, the test will be extended for these new commands. Related to: https://pykickstart.readthedocs.io/en/latest/kickstart-docs.html#firewall
Extracts function _write_it_comma_list to prevent code duplication and simplify.
evgenyz
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we will add option for managing firewall rules
during the installation:
firewall enable service_name- addsservice_nameto list in the--service=option in thefirewallcommand in commands section inthe kickstart
firewall disable service_name- addsservice_nameto list in the--remove-service=option in thefirewallcommand in commandssection in the kickstart
Also, the test will be extended for these new commands.
Related to:
https://pykickstart.readthedocs.io/en/latest/kickstart-docs.html#firewall