Fix new compiler warnings #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing:
In file included from /home/jcerny/work/git/openscap/src/common/elements.c:43:
/home/jcerny/work/git/openscap/src/common/elements.c: In function ‘oscap_xml_save_filename’:
/home/jcerny/work/git/openscap/src/common/elements.c:237:41: warning: passing argument 4 of ‘__oscap_setxmlerr’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
237 | oscap_setxmlerr(xmlGetLastError());
| ^~~~~~~~~~~~~~~~~
/home/jcerny/work/git/openscap/src/common/_error.h:36:92: note: in definition of macro ‘oscap_setxmlerr’
36 | #define oscap_setxmlerr(error) __oscap_setxmlerr (__FILE__, __LINE__, __PRETTY_FUNCTION__, error)
| ^~~~~
/home/jcerny/work/git/openscap/src/common/_error.h:38:87: note: expected ‘xmlErrorPtr’ {aka ‘struct _xmlError *’} but argument is of type ‘const xmlError *’ {aka ‘const struct _xmlError *’}
38 | void __oscap_setxmlerr(const char *file, uint32_t line, const char *func, xmlErrorPtr error);
| ~~~~~~~~~~~~^~~~~
Addressing:
In function ‘ipv6addr_mask’,
inlined from ‘ipaddr_mask’ at /home/jcerny/work/git/openscap/src/OVAL/results/oval_cmp_ip_address.c:79:3,
inlined from ‘ipaddr_mask’ at /home/jcerny/work/git/openscap/src/OVAL/results/oval_cmp_ip_address.c:74:20,
inlined from ‘oval_ipaddr_cmp’ at /home/jcerny/work/git/openscap/src/OVAL/results/oval_cmp_ip_address.c:171:3:
/home/jcerny/work/git/openscap/src/OVAL/results/oval_cmp_ip_address.c:280:34: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
280 | addr->s6_addr[i] &= mask;
| ~~~~~~~~~~~~~~~~~^~~~~~~
/home/jcerny/work/git/openscap/src/OVAL/results/oval_cmp_ip_address.c: In function ‘oval_ipaddr_cmp’:
/home/jcerny/work/git/openscap/src/OVAL/results/oval_cmp_ip_address.c:98:14: note: at offset [-268435456, -1] into destination object ‘addr2’ of size 46
98 | char addr2[INET6_ADDRSTRLEN];
| ^~~~~
Addressing:
/home/jcerny/work/git/openscap/src/source/bz2.c: In function ‘bz2_mem_open’:
/home/jcerny/work/git/openscap/src/source/bz2.c:127:43: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
127 | struct bz2_mem *b = calloc(sizeof(struct bz2_mem), 1);
| ^~~~~~
/home/jcerny/work/git/openscap/src/source/bz2.c:127:43: note: earlier argument should specify number of elements, later size of each element
/home/jcerny/work/git/openscap/src/source/bz2.c:128:35: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
128 | b->stream = calloc(sizeof(bz_stream), 1);
| ^~~~~~~~~
/home/jcerny/work/git/openscap/src/source/bz2.c:128:35: note: earlier argument should specify number of elements, later size of each element
This was referenced Jun 4, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These compiler warnings appeared with latest GCC on F40 (gcc-14.1.1-4.fc40.x86_64).
This should solve the failing "Build, Test on Fedora Latest" CI job.
For more details, please read commit messages of each commit.