Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Tiot/openriak 3.4/tictacaae and nextgenrepl cli commands #55

Open
wants to merge 18 commits into
base: openriak-3.4
Choose a base branch
from
Open

WIP Tiot/openriak 3.4/tictacaae and nextgenrepl cli commands #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fa26da7
set/print tictacaae_* settings via riak admin
hmmr Dec 4, 2024
2647b26
aae_schedule_nextrebuild
hmmr Dec 10, 2024
19553b5
getters of various vnode state fields needed for `riak admin aae-prog…
hmmr Dec 12, 2024
1b3b260
riak admin treestatus (aka aae-progress-report)
hmmr Dec 12, 2024
be49b51
correct kv_index_tictactree tag
hmmr Dec 16, 2024
96231e4
use getopt facilities for parsing tictacaae_cmd options
hmmr Dec 18, 2024
abdf158
final kv_index_tictactree tag
hmmr Dec 19, 2024
773440f
update meck version (#22)
hmmr Dec 19, 2024
a27da00
Proposal 10: TicTac AAE and NextGenRepl CLI commands, part 1/n
hmmr Dec 26, 2024
400247a
delete stray debugging aids
Jan 12, 2025
671950c
set/show af1, af4, be worker pool sizes
Jan 13, 2025
f838376
validate args; accept "0xfafa"-style binaries
Jan 15, 2025
d0f7fe5
access object_splitfun field in aae_controller state directly
Jan 15, 2025
9921ba9
temp switch deps to tiot branches
Jan 15, 2025
a0c616a
tweaks to strings
Jan 21, 2025
7533730
more tweaks to strings
Jan 23, 2025
86b0a35
wip, much perplexion and stupefication
Jan 23, 2025
b68a6bd
open and close outfile in the spawned process
Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@
]}.

{profiles, [
{test, [{deps, [meck]}]},
{test, [{deps, [{meck, {git, "https://github.com/OpenRiak/meck.git", {branch, "openriak-3.2"}}}]}]},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloning your own version of meck seems to me the wrong way to go

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with our approach everywhere, which is to clone all repos we depend on - only we didn't do it previously for test.

If we just get meck latest, as was - we're subject to time-expensive surprises when all our deps can no longer update. If we tag to a version, then we still need to check upstream for critical updates.

There's no perfect solution, so I'm happy that in this case we should resolve with the same solution used for non-test dependencies.

{gha, [{erl_opts, [{d, 'GITHUBEXCLUDE'}]}]}
]}.

{deps, [
{riak_core, {git, "https://github.com/OpenRiak/riak_core.git", {branch, "openriak-3.4"}}},
{riak_core, {git, "https://github.com/TI-Tokyo/riak_core.git", {branch, "tiot/openriak-3.4/tictacaae-and-nextgenrepl-cli-commands"}}},
{sidejob, {git, "https://github.com/OpenRiak/sidejob.git", {branch, "openriak-3.2"}}},
{bitcask, {git, "https://github.com/OpenRiak/bitcask.git", {branch, "openriak-3.2"}}},
{redbug, {git, "https://github.com/OpenRiak/redbug", {branch, "openriak-3.2"}}},
Expand All @@ -46,6 +46,6 @@
{riak_dt, {git, "https://github.com/OpenRiak/riak_dt.git", {branch, "openriak-3.2"}}},
{riak_api, {git, "https://github.com/OpenRiak/riak_api.git", {branch, "openriak-3.4"}}},
{hyper, {git, "https://github.com/OpenRiak/hyper", {branch, "openriak-3.2"}}},
{kv_index_tictactree, {git, "https://github.com/OpenRiak/kv_index_tictactree.git", {branch, "openriak-3.4"}}},
{kv_index_tictactree, {git, "https://github.com/TI-Tokyo/kv_index_tictactree.git", {branch, "tiot/openriak-3.4/tictacaae-and-nextgenrepl-cli-commands"}}},
{rhc, {git, "https://github.com/OpenRiak/riak-erlang-http-client", {branch, "openriak-3.4"}}}
]}.
Loading
Loading