Introduce alternative backend for hashtree #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial refactor of hashtree to separate out the function of the eleveldb backend, to prepare for the setup and testing of alternate backends.
Initial draft attempt to replicate eleveldb backend functionality in leveled. Requires resolution to martinsumner/leveled#413
Allow for close to be performed in an order that avoids delays
and remove logging added for testing
|
Depends on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts out the backend (i.e. storage and snapshot) elements of the hashtree implementation into a dedicated module, to make it easier to provide alternative implementations - specifically one which uses leveled not eleveldb.
to make this work effectively an extension of the API is required, whenever a group of hashtrees which potentially share a hashtree store are closed, they should be closed used
hashtree:close_group/1not looping around the trees callinghashtree:close/2. This is the leveled backend can be closed more efficiently if snapshots are closed prior to the closing the store they are taken from.#1