Nhse d34 otp26 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from field-values to be RFC 7230 compliant.
Remove leading and trailing whitespaces
I'm still very new to Erlang but this seems pretty straightforward.
Bug in mochiweb_request:read_chunk_length/2 #188
Add OTP 25 to test matrix
Add a test for the chunked encoding fix
Added overview section. Added getting started section and a tutorial. Added benefits section. Added documentation section. Added contributing section.
Updated with the suggested changes
Fixed typo in line 5.
Update README.md
Fix rebar edoc and test in CI
This function can used during long running request callbacks to detect if the client connection is closed. If the request callback periodically streams data back to the client, the act of writting to the client socket will detect if it is closed or not. However, in cases when no data is sent back, and the client times-out and closes the connection, it may be useful to be able to find out early and stop processing the request on the server. It turns out there is no easy way to detect if a passive mode socket is closed in Erlang/OTP [1]. Neither one of inet:monitor/1, inet:info/1, inet:getstat/1 work. However, it is possible to do it by querying the TCP state info of the socket. That option available in Linux since kernel 2.4 and on other Unix-like OSes (NetBSD, OpenBSD, FreeBSD and MacOS). Windows also has a tcp info query method however it is not reacheable via the gensockopts(2) standard socket API, so it can't be queried from Erlang's inet:getopts/2 API. [1] Using the newer socket module it's possible to detect if a socket is closed by attempting a recv with a MSG_PEEK option. However, the regular gen_tcp OTP module doesn't have a recv() variant which takes extra options. In addition, the new socket implementation still feels rather experimental. (It's not the default even in the latest OTP 26 release).
Add mochiweb_request:is_closed/1 function
Update CHANGES and version for v3.2.0
Matching of floating-point zeroes will change in OTP-27 so that -0.0 will no longer match a non-negative 0.0. OTP-26.1 warns about such constructs, which in mochiweb results in: src/mochinum.erl:47:8: Warning: matching on the float 0.0 will no longer also match -0.0 in OTP 27. If you specifically intend to match 0.0 alone, write +0.0 instead. Fixed by switching from a match to a numerical comparison.
mochinum:digits/1: fix handling of -0.0 for OTP-26.1/27.0
* Use latest patch levels for 24 and 25. * Add 26 to the list. In Erlang 26 TLS `verify` option switched the default value from `verify_none` to `verify_peer` [1]. So had to explictly set it in the test client. [1] https://www.erlang.org/blog/otp-26-highlights/#ssl-safer-defaults
Update Erlang CI images
Use single quotes around 'maybe' atom for compatibility with OTP 27
ThomasArts
reviewed
May 15, 2024
| @@ -215,6 +215,9 @@ tokenize_header_value(undefined) -> | |||
| tokenize_header_value(V) -> | |||
| reversed_tokens(trim_and_reverse(V, false), [], []). | |||
|
|
|||
| trim_leading_and_trailing_ws(S) -> | |||
There was a problem hiding this comment.
Since otp20 there is string:trim(S, both) that would help you a long way...
But possibly some other guarantees are given here.
There was a problem hiding this comment.
I think there may be a difference in the handling of "\r", which isn't referred to in this function. For now, I'm preferring to de-risk the change and not make any assumptions.
ThomasArts
reviewed
May 15, 2024
ThomasArts
reviewed
May 15, 2024
ThomasArts
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from mochi/mochiweb for OTP 26 compliance