WIP Expose some controller state fields for Tictac AAE and NextGenRepl CLI commands #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmmr
force-pushed
the
tiot/openriak-3.4/tictacaae-and-nextgenrepl-cli-commands
branch
from
39ef95d to
e3d7ee7
Compare
hmmr
changed the title
ThomasArts
reviewed
Jan 5, 2025
src/aae_controller.erl
Outdated
| ]). | ||
|
|
||
| -export([foldobjects_buildtrees/2, | ||
| hash_clocks/2, | ||
| wrapped_splitobjfun/1]). | ||
|
|
||
| -export([get_key_store/1, |
There was a problem hiding this comment.
Since you are not supposed to make the state of a gen_server visible outside the gen_server itself, one should not export functions that take that state as input argument.
This is possibly a remainder of an experiment, but I propose to drop those functions and in particular not exporting them.
There was a problem hiding this comment.
Yeah, it's wip at the moment. I should probably have taken it private until it's ready.
added 3 commits
January 5, 2025 22:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds getters for some controller state records, needed for TicTac AAE and NextGenRepl CLI commands (main body of work is in this PR in riak_kv).
Also, we add a new function,
aae_schedulenextrebuild/2, which can be used to trigger a tree rebuild, at a specified delay.