Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-setup exometer_core #1

Open
wants to merge 1 commit into
base: openriak-3.4
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions rebar.config
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
{deps,
[
{parse_trans, {git, "https://github.com/OpenRiak/parse_trans.git", {branch, "openriak-3.2"}}},
{hut, {git, "https://github.com/OpenRiak/hut.git", {branch, "openriak-3.2"}}},
{setup, {git, "https://github.com/OpenRiak/setup.git", {branch, "openriak-3.2"}}}
{hut, {git, "https://github.com/OpenRiak/hut.git", {branch, "openriak-3.2"}}}
]}.

{project_plugins, [rebar3_ex_doc]}.
Expand Down
10 changes: 5 additions & 5 deletions src/exometer_admin.erl
Original file line number Diff line number Diff line change
Expand Up @@ -87,28 +87,28 @@ load_defaults() ->
E = exometer_util:get_env(defaults, []),
do_load_defaults(env, get_predef(E)),
[do_load_defaults(Src, get_predef(D))
|| {Src,D} <- setup:find_env_vars(exometer_defaults)],
|| {Src,D} <- exometer_util:find_env_vars(exometer_defaults)],
ok.

load_predefined() ->
E = exometer_util:get_env(predefined, []),
do_load_predef(env, get_predef(E)),
[do_load_predef(Src, get_predef(P))
|| {Src, P} <- setup:find_env_vars(exometer_predefined)],
|| {Src, P} <- exometer_util:find_env_vars(exometer_predefined)],
ok.

register_application(App) ->
%% Ignore if exometer is not running
case whereis(exometer_admin) of
undefined -> ok;
_ ->
case setup:get_env(App, exometer_defaults) of
case application:get_env(App, exometer_defaults) of
{ok, E} ->
do_load_defaults(App, get_predef(E));
undefined ->
ok
end,
case setup:get_env(App, exometer_predefined) of
case application:get_env(App, exometer_predefined) of
{ok, P} ->
do_load_predef(App, get_predef(P));
undefined ->
Expand All @@ -127,7 +127,7 @@ do_load_defaults(Src, L) when is_list(L) ->
try set_default(NamePattern, Type, Spec)
catch
error:E ->
?log(error, "Defaults(~p): ERROR: ~p~n", [Src, E])
?log(error, "Defaults(~p): ERROR: ~p~n", [Src, E])
end
end, L).

Expand Down
2 changes: 1 addition & 1 deletion src/exometer_core.app.src
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
[{description,"Code instrumentation and metrics collection package."},
{vsn,git},
{registered,[]},
{applications,[kernel,stdlib,hut,setup,parse_trans]},
{applications,[kernel,stdlib,hut,parse_trans]},
{included_applications,[]},
{mod,{exometer_core_app,[]}},
{start_phases,[{start_reporters,[]},{preset_defaults,[]}]},
Expand Down
4 changes: 2 additions & 2 deletions src/exometer_report.erl
Original file line number Diff line number Diff line change
Expand Up @@ -813,12 +813,12 @@ split_env(Tag, Opts) ->

get_reporters(L0) ->
Rs = exometer_util:get_env(reporters, []),
Ext = setup:find_env_vars(exometer_reporters),
Ext = exometer_util:find_env_vars(exometer_reporters),
merge_env(reporters, Rs ++ L0, Ext).

get_subscribers(L0) ->
Ss = exometer_util:get_env(subscribers, []),
Ext = setup:find_env_vars(exometer_subscribers),
Ext = exometer_util:find_env_vars(exometer_subscribers),
merge_env(subscribers, Ss ++ L0, Ext).

merge_env(_, [], []) -> [];
Expand Down
15 changes: 15 additions & 0 deletions src/exometer_util.erl
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
timestamp_to_datetime/1,
get_opt/2,
get_opt/3,
find_env_vars/1,
get_env/2,
tables/0,
table/0,
Expand Down Expand Up @@ -80,6 +81,20 @@ timestamp_to_datetime(TS) when TS >= 0 ->
%% return {Datetime, Milliseconds}
{calendar:now_to_datetime({1258,S,0}), MS}.

find_env_vars(Env) ->
lists:flatmap(
fun({A,_,_}) ->
case application:get_env(A, Env) of
{ok, Val} when Val =/= undefined ->
[{A, Val}];
_ ->
[]
end
end,
application:loaded_applications()
).


get_env(Key, Default) ->
case get_env1(exometer, Key) of
{ok, Value} ->
Expand Down