Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 94 File thumbnails don't show up after upload of new files #153

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

sunilnatraj
Copy link
Contributor

Issue - 94
Media preview fails to load in case of new data as the newly added data do not contain the prefix "File:".
Updated code to handle the scenario of missing prefix "Fiile:"

Projects uploading new media do not contain the File prefix in the file name. Added check to get proper filename when the prefix File: is missing.
@sunilnatraj
Copy link
Contributor Author

@wetneb Please review

Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's curious that there is this discrepancy. It would probably be worth adjusting the upload code so that it adds the File: prefix to the uploaded files, so that existing and uploaded files are reprersented in the same way in the grid.

@wetneb
Copy link
Member

wetneb commented Nov 18, 2024

Note: I haven't tested this yet, I might have an occasion this week-end to try it out. Leaving it open also for @sebastian-berlin-wmse to have the opportunity to chime in.

@sunilnatraj
Copy link
Contributor Author

Thanks! It's curious that there is this discrepancy. It would probably be worth adjusting the upload code so that it adds the File: prefix to the uploaded files, so that existing and uploaded files are reprersented in the same way in the grid.
@wetneb In case of new data as post upload the local data is not updated there is the discrepancy in file property. We cannot add the prefix in the new data as that will break the file validation rule - "file cannot have special character :"

@wetneb
Copy link
Member

wetneb commented Nov 18, 2024

I have opened OpenRefine/OpenRefine#6996 about this.

I do not mean that the user should add the File: prefix themselves. I mean that OpenRefine itself should add the File: prefix when changing the cells reconciled to "New" to cells reconciled to the newly-created files.

@sunilnatraj
Copy link
Contributor Author

@wetneb Can this PR be merged?

@wetneb wetneb merged commit 378bf1b into OpenRefine:master Dec 5, 2024
1 check passed
@sunilnatraj sunilnatraj deleted the issue-94 branch December 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants