-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 94 File thumbnails don't show up after upload of new files #153
Conversation
Projects uploading new media do not contain the File prefix in the file name. Added check to get proper filename when the prefix File: is missing.
@wetneb Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's curious that there is this discrepancy. It would probably be worth adjusting the upload code so that it adds the File:
prefix to the uploaded files, so that existing and uploaded files are reprersented in the same way in the grid.
Note: I haven't tested this yet, I might have an occasion this week-end to try it out. Leaving it open also for @sebastian-berlin-wmse to have the opportunity to chime in. |
|
I have opened OpenRefine/OpenRefine#6996 about this. I do not mean that the user should add the |
@wetneb Can this PR be merged? |
Co-authored-by: Antonin Delpeuch <[email protected]>
Issue - 94
Media preview fails to load in case of new data as the newly added data do not contain the prefix "File:".
Updated code to handle the scenario of missing prefix "Fiile:"