Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stdcm: persist user-entered date and time in the interface #8942

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SarahBellaha
Copy link
Contributor

@SarahBellaha SarahBellaha requested a review from a team as a code owner September 20, 2024 07:06
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 24.61538% with 49 lines in your changes missing coverage. Please review.

Project coverage is 37.13%. Comparing base (68e0513) to head (9b814b4).

Files with missing lines Patch % Lines
...plications/stdcmV2/components/StdcmDestination.tsx 0.00% 21 Missing and 1 partial ⚠️
...rc/applications/stdcmV2/components/StdcmOrigin.tsx 0.00% 19 Missing and 1 partial ⚠️
...pplications/stdcmV2/components/StdcmOpSchedule.tsx 0.00% 4 Missing ⚠️
...ront/src/reducers/osrdconf/osrdConfCommon/index.ts 50.00% 0 Missing and 2 partials ⚠️
front/src/utils/date.ts 93.33% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8942      +/-   ##
============================================
- Coverage     37.13%   37.13%   -0.01%     
  Complexity     2211     2211              
============================================
  Files          1260     1260              
  Lines        115076   115120      +44     
  Branches       3230     3234       +4     
============================================
+ Hits          42736    42746      +10     
- Misses        70407    70437      +30     
- Partials       1933     1937       +4     
Flag Coverage Δ
core 74.67% <ø> (ø)
editoast 72.55% <ø> (-0.02%) ⬇️
front 15.21% <24.61%> (+<0.01%) ⬆️
gateway 2.20% <ø> (ø)
osrdyne 2.60% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +240 to +241
date: Date,
{ hours, minutes }: { hours: number; minutes: number }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really an issue, just a suggestion: we could create an explicit type instead of repeating those parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants