Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: bump osrd-ui to 0.0.42 #8920

Merged
merged 1 commit into from
Sep 20, 2024
Merged

front: bump osrd-ui to 0.0.42 #8920

merged 1 commit into from
Sep 20, 2024

Conversation

kmer2016
Copy link
Contributor

No description provided.

@kmer2016 kmer2016 requested a review from a team as a code owner September 19, 2024 08:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.14%. Comparing base (fbf8e3e) to head (bc57b99).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8920      +/-   ##
============================================
- Coverage     37.14%   37.14%   -0.01%     
  Complexity     2211     2211              
============================================
  Files          1260     1260              
  Lines        115060   115060              
  Branches       3230     3230              
============================================
- Hits          42738    42736       -2     
- Misses        70389    70391       +2     
  Partials       1933     1933              
Flag Coverage Δ
core 74.67% <ø> (ø)
editoast 72.56% <ø> (-0.01%) ⬇️
front 15.20% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.60% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested (if its normal that the back always returns a date in June)

Capture d’écran 2024-09-19 à 10 37 37

@SharglutDev
Copy link
Contributor

Just one thing that could be clarified with @thibautsailly : it would be nice that the calendar modal closes when we selected a date (currently we need to click outside of the modal)

@kmer2016 kmer2016 added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@kmer2016 kmer2016 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into dev with commit 8d1935a Sep 20, 2024
23 checks passed
@kmer2016 kmer2016 deleted the cnh/front/bump-osrd-ui-0.0.42 branch September 20, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants