front: add some data sources and licenses #8904
Open
+92
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8904 +/- ##
============================================
+ Coverage 36.98% 37.13% +0.14%
Complexity 2211 2211
============================================
Files 1259 1260 +1
Lines 114565 115096 +531
Branches 3192 3230 +38
============================================
+ Hits 42374 42737 +363
- Misses 70290 70426 +136
- Partials 1901 1933 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yohh
reviewed
Sep 17, 2024
|
I wonder if we could/should add a copy of the licenses in the project |
- add some data sources and licenses - refacto the licenseAttribution component to separe the data sources and the licenses
clarani
force-pushed
the
cni/7621-add-sources-licenses
branch
from
1303fae
to
0f471af
Compare
Yohh
approved these changes
Sep 19, 2024
SharglutDev
reviewed
Sep 19, 2024
| const LicenseCard = ({ | ||
| attribution: { name, version, copyright, publisher, url, license }, | ||
| }: LicenseCardProps) => ( | ||
| <a key={name} href={url} rel="noreferrer"> |
There was a problem hiding this comment.
There is a warning in console
…ces and licenses - refacto the licenseAttribution component to separe the data sources and the licenses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7621