-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix the warning display above the GET #8880
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8880 +/- ##
============================================
- Coverage 37.13% 37.13% -0.01%
Complexity 2211 2211
============================================
Files 1260 1260
Lines 115076 115085 +9
Branches 3230 3230
============================================
- Hits 42738 42735 -3
- Misses 70405 70417 +12
Partials 1933 1933
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fd57bf9
to
9484d48
Compare
Could we instead use a |
0b8f30b
to
4b4de7f
Compare
@anisometropie thanks for your review 🙏
|
Another way to fix this without a desync would be to subtract the number of invalid trains to the total number of simulated trains. But the current approach here looks fine to me as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
front/src/modules/simulationResult/components/SpaceTimeChart/useLazyProjectTrains.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM regardless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4b4de7f
to
e499318
Compare
- Add a new boolean allTrainsProjected and display the warning "Projecting..." only if this boolean is not truthy. - Transform trainIdsToProject into a set (instead of array)
e499318
to
0bc4624
Compare
closes #8878
Add a new boolean allTrainsProjected and display the warning "Projecting..." only if this boolean is not truthy.