Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-speedspacechart: fix detailsBox display #99

Merged
merged 1 commit into from
Jul 11, 2024
Merged

ui-speedspacechart: fix detailsBox display #99

merged 1 commit into from
Jul 11, 2024

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Jul 9, 2024

  • add showReticleLayer state in SpeedSpaceChart.tsx
  • display or not ReticleLayer while onMouseDown or onMouseLeave SettingsPanel

close #98

@Yohh Yohh requested review from Akctarus and SharglutDev July 9, 2024 14:44
@Yohh Yohh force-pushed the yoh/ui-speedspacechart-fix-detailsbox-display branch from 93b631f to 58f0111 Compare July 10, 2024 07:36
@clarani clarani changed the title ui-speedspacechart: fix-detailsbox-display ui-speedspacechart: fix detailsBox display Jul 10, 2024
Akctarus
Akctarus approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

clarani
clarani requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
You still have an issue if the cursor is near the panel.

I also have the issue if I hover a PR.
image

ui-speedspacechart/src/components/common/SettingsPanel.tsx Outdated Show resolved Hide resolved
@Yohh Yohh requested a review from a team as a code owner July 10, 2024 13:27
@Yohh Yohh requested a review from clarani July 10, 2024 14:37
SharglutDev
SharglutDev reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix, left some suggestions.

ui-speedspacechart/src/components/SpeedSpaceChart.tsx Outdated Show resolved Hide resolved
ui-speedspacechart/src/components/SpeedSpaceChart.tsx Outdated Show resolved Hide resolved
@Yohh Yohh force-pushed the yoh/ui-speedspacechart-fix-detailsbox-display branch from 80461f2 to f6158b3 Compare July 11, 2024 10:22
@Yohh Yohh requested a review from SharglutDev July 11, 2024 10:23
clarani
clarani approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested ✅

@Yohh
ui-speedspacechart: fix-detailsbox-display
b6f2d0f 
- add showReticleLayer state in SpeedSpaceChart.tsx
- display or not ReticleLayer while onMouseDown or onMouseLeave SettingsPanel
@Yohh Yohh force-pushed the yoh/ui-speedspacechart-fix-detailsbox-display branch from f6158b3 to b6f2d0f Compare July 11, 2024 11:19
@Math-R Math-R added this pull request to the merge queue Jul 11, 2024
@Math-R Math-R removed this pull request from the merge queue due to a manual request Jul 11, 2024
Math-R
Math-R approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and tested to

@Math-R Math-R added this pull request to the merge queue Jul 11, 2024
Merged via the queue into dev with commit 9b03a64 Jul 11, 2024
3 checks passed
@Math-R Math-R deleted the yoh/ui-speedspacechart-fix-detailsbox-display branch July 11, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisometropie anisometropie anisometropie approved these changes

@Akctarus Akctarus Akctarus approved these changes

@Math-R Math-R Math-R approved these changes

@clarani clarani clarani approved these changes

@SharglutDev SharglutDev Awaiting requested review from SharglutDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui-speedspacechart : hide reticle and detailsbox when hovering settings panel
6 participants
@Yohh @anisometropie @Math-R @clarani @Akctarus @SharglutDev