first steps of project industrialisation #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kmer2016
commented
Apr 8, 2024
•
kmer2016
commented
- Add some component of design system
- set project architecture
- create-react-app ui-speedspacechart - add taillwindcss using PostCSS - copy /ui-core/styles/main.css to replace /ui-speedspacechart/index.css - import main.css in index.tsx, remove import from App.tsx - edit tailwind.config.js - add IBMPlex fonts to /public - add storybook, clean /stories - clean unnecessary files
- create speedSpaceChart story - create useCanvas custom hook - create: - SpeedSpaceChart.tsx - FrontInterractivityLayer.tsx - GridLayer.tsx - CurveLayer.tsx - add draw function in drawElements.ts - copy simulation consts and types from osrd - copy sampleData from osrd
- add ticks on axis - add d3 zoom function for zoom and reset - replace speed props with full store props
Details: - Drafts WarpedMap, based on existing code from OSRD, but without all the business specific code - Drafts first story (but cannot run it because of missing data) TODO: - Add missing features: - Allow syncing bbox - Allow refining data (ie. reloading OSRD entities) - Allow adding custom buttons (to set bbox sync mode) - Add missing data to base story
Details: - Adds sample paths and OSM styles - Adds an optional timeout to DataLoader - Fixes various minor issues to get a proper first rendered map TODO: - Add missing features, detailed in previous commit
Details: - Makes every setting from getWarping overridable - Adds inputs for all warping settings in algorithm showcase stories
Details: - Intersects polygons with zone instead of clipping them (this makes large areas of water for instance being properly drawn around the grid) - Fixes various issues that caused properties to not be properly set to the warped data - Fixes TransformedDataMap filters to take source-layers into account
- monorepo project with sub-packages which allow us to share dep, scripts, ... - rollup configuration (remove commonjs, babel, and adding postcss) - package.json with export - remove CRA trace - adding a stroybook package that read stories across project - adding lerna for release
* ui-core: implement anatomy input ui-core: use css instead of full tailwind class ui-core: handle small input ui-core: readme v1 ui-core: implement disabled & readonly ui-core: fix height of component, use bowshadow instead of border ui-core: fix small input ui-core: fix style on focus via keyboard ui-core: use box shadow fof leading/trailing iu-core: fix blur ui-core: implement token input fix border using box shadow ui-core: add form validation refacto style refacto. use scss power to handle small version of input more clearly * ui-core: wrap token input * ui-core: password input * Fix story book and styles * ui-core: export Input, TokenInput and PasswordInput --------- Co-authored-by: Benoit Simard <[email protected]>
…-prettier-conf osrd-ui: normalize eslint and prettier conf
…config-for-storybook-hot-reload ui-core: optimize rollup config for storybook hotreload
* osrd-ui: build and check code * fix prettier error * osrd-ui: ignore prettier error from component generated by ui-icons * osrd-ui: enable hot reload only when we are in development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.