build: use rollup --failAfterWarnings

We've got to a point where we've eliminated almost all build errors. We previously did not notice these because they only show up as warnings in CI, without making CI fail. Use rollup --failAfterWarnings so that CI fails when a build error is emitted. Leave ui-spacetimechart and ui-trackoccupancydiagram alone, because these still have a failure due to a circular dependency: (!) [plugin typescript] ../ui-spacetimechart/src/lib/types.ts (6:8): @rollup/plugin-typescript TS2307: Cannot find module '@osrd-project/ui-trackoccupancydiagram/dist/components/types' or its corresponding type declarations. /home/runner/work/osrd-ui/osrd-ui/ui-spacetimechart/src/lib/types.ts:6:8 6 } from '@osrd-project/ui-trackoccupancydiagram/dist/components/types'; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Simon Ser <[email protected]>
OpenRailAssociation · Feb 19, 2025 · 04acca9 · 04acca9
1 parent 2163a9b
commit 04acca9
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 13 deletions.
diff --git a/ui-core/package.json b/ui-core/package.json
@@ -27,9 +27,8 @@
     }
   },
   "scripts": {
-    "rollup": "rollup -c",
     "clean": "rimraf dist",
-    "build": "npm run rollup",
+    "build": "rollup -c --failAfterWarnings",
     "watch": "rollup -c -w",
     "test": "vitest run",
     "prepublishOnly": "npm run clean && npm run build",

diff --git a/ui-icons/package.json b/ui-icons/package.json
@@ -26,10 +26,8 @@
   },
   "scripts": {
     "svgo": "svgo icons --config svgo.config.cjs",
-    "build-components": "node ./scripts/build.js",
-    "rollup": "rollup -c",
     "clean": "rimraf dist",
-    "build": "npm run build-components && npm run rollup",
+    "build": "node ./scripts/build.js && rollup -c --failAfterWarnings",
     "prepublishOnly": "npm run clean && npm run build"
   },
   "peerDependencies": {

diff --git a/ui-manchette-with-spacetimechart/package.json b/ui-manchette-with-spacetimechart/package.json
@@ -27,9 +27,8 @@
     }
   },
   "scripts": {
-    "rollup": "rollup -c",
     "clean": "rimraf dist",
-    "build": "npm run rollup",
+    "build": "rollup -c --failAfterWarnings",
     "watch": "rollup -c -w",
     "prepublishOnly": "npm run clean && npm run build",
     "lint": "eslint src --max-warnings 0",

diff --git a/ui-manchette/package.json b/ui-manchette/package.json
@@ -27,9 +27,8 @@
     }
   },
   "scripts": {
-    "rollup": "rollup -c",
     "clean": "rimraf dist",
-    "build": "npm run rollup",
+    "build": "rollup -c --failAfterWarnings",
     "watch": "rollup -c -w",
     "prepublishOnly": "npm run clean && npm run build",
     "lint": "eslint src --max-warnings 0",

diff --git a/ui-speedspacechart/package.json b/ui-speedspacechart/package.json
@@ -27,9 +27,8 @@
     }
   },
   "scripts": {
-    "rollup": "rollup -c",
     "clean": "rimraf dist",
-    "build": "npm run rollup",
+    "build": "rollup -c --failAfterWarnings",
     "watch": "rollup -c -w",
     "test": "vitest run --dir src/__tests__",
     "prepublishOnly": "npm run clean && npm run build",

diff --git a/ui-warped-map/package.json b/ui-warped-map/package.json
@@ -27,9 +27,8 @@
     }
   },
   "scripts": {
-    "rollup": "rollup -c",
     "clean": "rimraf dist",
-    "build": "npm run rollup",
+    "build": "rollup -c --failAfterWarnings",
     "watch": "rollup -c -w",
     "prepublishOnly": "npm run clean && npm run build",
     "lint": "eslint src --max-warnings 0",