Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: make liveness probe configurable #10

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Jul 1, 2024

No description provided.

@bloussou bloussou requested a review from ElysaSrc July 1, 2024 17:15
@bloussou bloussou force-pushed the bloussou/EditoastLivenessProbe branch from bdb5b17 to d6ba624 Compare July 2, 2024 07:28
Copy link
Contributor

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

values.yaml Outdated
@@ -37,6 +37,10 @@ editoast:
type: ClusterIP
port: 80
targetPort: 80
livenessProbe:
initialDelaySeconds: 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today this value is set to 0 (default). I think we can keep it that way.

@bloussou bloussou force-pushed the bloussou/EditoastLivenessProbe branch from d6ba624 to 47ba0b8 Compare July 2, 2024 07:34
@bloussou bloussou merged commit 667b602 into main Jul 2, 2024
1 check passed
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants