CI: Add github code quality analysis (codeql)

[thesamesam]

No description provided.

[N-R-K]

The following patch should solve one of the issues reported in the codeql scan. It also removes usage of utime which seems to be deprecated by POSIX ¹

diff --git a/src/swclock/swclock.c b/src/swclock/swclock.c
index e526bd38..83b15c95 100644
--- a/src/swclock/swclock.c
+++ b/src/swclock/swclock.c
@@ -78,14 +78,12 @@ int main(int argc, char **argv)
 		eerrorx("swclock: Reference file was not specified");
 
 	if (sflag) {
-		if (stat(file, &sb) == -1) {
-			opt = open(file, O_WRONLY | O_CREAT, 0644);
-			if (opt == -1)
-				eerrorx("swclock: open: %s", strerror(errno));
-			close(opt);
-		} else
-			if (utime(file, NULL) == -1)
-				eerrorx("swclock: utime: %s", strerror(errno));
+		int fd = open(file, O_WRONLY | O_CREAT, 0644);
+		if (fd == -1)
+			eerrorx("swclock: open: %s", strerror(errno));
+		if (futimens(fd, NULL) == -1)
+			eerrorx("swclock: futimens: %s", strerror(errno));
+		close(fd);
 		return 0;
 	}
 

Footnotes

1. https://www.man7.org/linux/man-pages/man3/utime.3p.html#FUTURE_DIRECTIONS ↩

[vapier]

can you send a PR ? we're not going to copy & paste patches from comments ...

[N-R-K]

can you send a PR ? we're not going to copy & paste patches from comments ...

Sure. I was thinking @thesamesam might have wanted to add that to this PR since it's somewhat related.

EDIT: done at #591