Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .editorconfig to match the new one from the OpenRA repository #194

Closed
wants to merge 1 commit into from

Conversation

oldnaari
Copy link

Recently my mod began to refuse to pass the CI. Copying the .editorconfig from https://github.com/OpenRA/OpenRA/blob/bleed/.editorconfig was an important component for fixing that. So here it comes )

@penev92
Copy link
Member

penev92 commented Nov 3, 2023

Hi there and thanks for the PR.
I already had a commit for the .editorconfig file in #193, but I don't mind dropping that in favor of this PR.
However, you seem to have copied the file from OpenRA's bleed branch, which is about 10 commits ahead of release-20231010.
Currently the ModSDK has a single master branch that targets OpenRA releases and very rarely gets patches inbetween. I'd say you should either take the release version of the file and we merge this before #193 or you wait for that to get merged and then this can be merged as an inbetween-releases patch.

@oldnaari
Copy link
Author

oldnaari commented Nov 3, 2023

Hello @penev92. My bad didn't see the pull request. I will better wait for #193 in that case

@abcdefg30
Copy link
Member

#193 was merged so you can rebase this.

@oldnaari
Copy link
Author

oldnaari commented Nov 6, 2023

I think we can close this pull request for now. What I wanted to achieve here is done by #193 in a more thoughtful manner.

@oldnaari oldnaari closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants