[AutoTimer] fix logic checkSimilarity #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) At this point(Short Descriptions) we assume the similarity match to be True unless we have been asked to check Extended Descriptions and we have *both* Extended Descriptions in place; in which case we test them. 2)Remove shortdesc1 in shortdesc2 This is not true in principle and breaks all logic ratio. E.g. shortdesc1 = "news" shortdesc2 = "Sunday news (weekly review)" shortdesc1 in shortdesc2 --> answer True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be True/False unless we have been asked to check Extended Descriptions and we
have both Extended Descriptions in place; in which case we test them.
2)Remove shortdesc1 in shortdesc2
This is not true in principle and breaks all logic ratio.
E.g.
shortdesc1 = "news"
shortdesc2 = "Sunday news (weekly review)"
shortdesc1 in shortdesc2 --> answer True
3)Remove unused old code(checkSimilarityOE)