Singend bclconvert samplesheet #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arser and bclconvert
skchronicles
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Hey @rroutsong,
Everything looks amazing! Can you please add a dry-run for SE datasets and update the README? Once added I can merge everything. Thank you for all your hard work, I appreciate it!
| @@ -71,16 +86,29 @@ if __name__ == '__main__': | |||
| help='Dry run the demultiplexing workflow') | |||
| parser_run.add_argument('-n', '--noqc', action='store_false', | |||
| help='Dry run the demultiplexing workflow') | |||
There was a problem hiding this comment.
Can you fix this help message? I just noticed it was a duplicate.
| will be written in such a way to embrace that modularity as best as possible with forward thinking kept in mind. If we | ||
| don't find utility in this work at a brace scale then we will accept the simple approach as bespoke and move forward. | ||
| Several of the applications that **weave** uses to visualize and report quality metrics are: | ||
| - [Kraken](https://github.com/DerrickWood/kraken2)<sup>71</sup>, kmer analysis |
There was a problem hiding this comment.
Please also change 71 to 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weave support for:
Addresses #20 #26 #19 and #18