Contribute: zfs driver and zfs driver shared over ISCSI

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,7 +1,7 @@
 ---
 name: Bug report
 about: Create a report to help us improve
-
+labels: 'Type: Bug'
 ---
 
 /!\ To report a **security issue** please follow this procedure:
@@ -17,7 +17,7 @@ Steps to reproduce the behavior.
 A clear and concise description of what you expected to happen.
 
 **Details**
- - Affected Component: [e.g. Sunstone, Scheduler or Storage]
+ - Affected Component: [e.g. Sunstone, Scheduler, or Storage]
  - Hypervisor: [e.g. KVM]
  - Version: [e.g. 5.4.12 or development]
 
@@ -31,10 +31,6 @@ Add any other context about the problem here.
 <!--////////////////////////////////////////////-->
 
 ## Progress Status
-- [ ] Branch created 
-- [ ] Code committed to development branch
+- [ ] Code committed
 - [ ] Testing - QA
-- [ ] Documentation 
-- [ ] Release notes - resolved issues, compatibility, known issues
-- [ ] Code committed to upstream release/hotfix branches
-- [ ] Documentation committed to upstream release/hotfix branches
+- [ ] Documentation (Release notes - resolved issues, compatibility, known issues)

.github/ISSUE_TEMPLATE/enhancement-request.md

@@ -1,7 +1,7 @@
 ---
 name: New Feature request
 about: Suggest an idea to improve OpenNebula
-
+labels: 'Type: Feature'
 ---
 
 **Description**
@@ -11,10 +11,10 @@ Brief description of the new functionality
 How are you going to use this new feature? Why do you need it?
 
 **Interface Changes**
-Describe any changed you'd like to see to current interfaces including Sunstone, CLI or/and API
+Describe any changes you'd like to see to current interfaces including Sunstone, CLI, or/and API
 
 **Additional Context**
-Add any other context or screenshots about the feature request here. Or any other alternative you have considered to addressed this new feature.
+Please feel free to add any other context or screenshots about the feature request here. Or any other alternative you have considered to address this new feature.
 
 <!--////////////////////////////////////////////-->
 <!-- THIS SECTION IS FOR THE DEVELOPMENT TEAM   -->
@@ -23,10 +23,6 @@ Add any other context or screenshots about the feature request here. Or any othe
 <!--////////////////////////////////////////////-->
 
 ## Progress Status
-- [ ] Branch created
-- [ ] Code committed to development branch
+- [ ] Code committed
 - [ ] Testing - QA
-- [ ] Documentation
-- [ ] Release notes - resolved issues, compatibility, known issues
-- [ ] Code committed to upstream release/hotfix branches
-- [ ] Documentation committed to upstream release/hotfix branches
+- [ ] Documentation (Release notes - resolved issues, compatibility, known issues)

.github/pull_request_template.md

@@ -0,0 +1,15 @@
+### Description
+
+<!--- Please leave a helpful description of the PR here. --->
+
+### Branches to which this PR applies
+
+<!--- Please check you didn't forget a branch this needs to be cherry picked to.
+      Leave them unchecked, they will be checked by the merger --->
+
+- [ ] master
+- [ ] one-X.X
+
+<hr>
+
+- [ ] Check this if this PR should **not** be squashed

.github/workflows/notify_push_slack.yml

@@ -0,0 +1,34 @@
+name: Slack Push Notifier
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    types: [closed]
+    branches: [master]
+  workflow_dispatch:
+
+jobs:
+  notify_slack_push:
+    name: Notify Slack on pushes
+    runs-on: ubuntu-latest
+    steps:
+
+      - name: String manipulation
+        run: echo "COMMIT_ONELINER=${{ github.event.head_commit.message }}${{ github.event.pull_request.title }}"|grep -v '^$'|head -1 >> $GITHUB_ENV
+
+      - name: It is a merged pull request
+        if: ${{ github.event_name == 'pull_request' && github.event.pull_request.merged == true  && github.repository == 'OpenNebula/one-ee' }}
+        uses: abinoda/slack-action@master
+        env:
+          SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
+        with:
+          args: '{\"channel\":\"${{ secrets.SLACK_CHANNEL_ID }}\",\"blocks\":[{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\" > --> *New PR merged:* <${{ github.event.pull_request.html_url }}|${{ env.COMMIT_ONELINER }}> (<${{ github.event.pull_request.html_url }}|PR>)\n\"}}]}' 
+
+      - name: It is a direct push
+        if: ${{ github.event_name == 'push' && github.repository == 'OpenNebula/one-ee' }}
+        uses: abinoda/slack-action@master
+        env:
+          SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
+        with:
+          args: '{\"channel\":\"${{ secrets.SLACK_CHANNEL_ID }}\",\"blocks\":[{\"type\":\"section\",\"text\":{\"type\":\"mrkdwn\",\"text\":\" > --> *New Commit:* <${{ github.event.head_commit.url }}|${{ env.COMMIT_ONELINER }}>\n\"}}]}' 

.github/workflows/smoke_tests.yml

@@ -3,6 +3,9 @@ name: OpenNebula Smoke Tests
 # Controls when the action will run.
 on: [push, pull_request, workflow_dispatch]
 
+permissions:
+  contents: read
+
 jobs:
   smoke-tests:
     runs-on: ubuntu-latest
@@ -11,11 +14,15 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.6
+          ruby-version: 2.7
       - name: Install rubocop
         run: gem install rubocop
+      - name: Install CppCheck
+        run: sudo apt install -y cppcheck
+      - name: Install AStyle
+        run: sudo apt install -y astyle
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       # Runs a single command using the runners shell
       - name: Run Smoke Tests

.gitignore

@@ -1,3 +1,5 @@
+.gitignore
+src/fireedge/package-lock.json
 *.a
 *.o
 *.pyc
@@ -68,7 +70,7 @@ share/esx-fw-vnc/*.rpm
 share/esx-fw-vnc/.vagrant*
 
 *.vscode
-
+*.code-workspace
 share/context/*
 !share/context/download_context.sh
 !share/context/SConstruct

CODE_OF_CONDUCT.md

@@ -0,0 +1,128 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+We as members, contributors, and leaders pledge to make participation in our
+community a harassment-free experience for everyone, regardless of age, body
+size, visible or invisible disability, ethnicity, sex characteristics, gender
+identity and expression, level of experience, education, socio-economic status,
+nationality, personal appearance, race, religion, or sexual identity
+and orientation.
+
+We pledge to act and interact in ways that contribute to an open, welcoming,
+diverse, inclusive, and healthy community.
+
+## Our Standards
+
+Examples of behavior that contributes to a positive environment for our
+community include:
+
+* Demonstrating empathy and kindness toward other people
+* Being respectful of differing opinions, viewpoints, and experiences
+* Giving and gracefully accepting constructive feedback
+* Accepting responsibility and apologizing to those affected by our mistakes,
+  and learning from the experience
+* Focusing on what is best not just for us as individuals, but for the
+  overall community
+
+Examples of unacceptable behavior include:
+
+* The use of sexualized language or imagery, and sexual attention or
+  advances of any kind
+* Trolling, insulting or derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or email
+  address, without their explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Enforcement Responsibilities
+
+Community leaders are responsible for clarifying and enforcing our standards of
+acceptable behavior and will take appropriate and fair corrective action in
+response to any behavior that they deem inappropriate, threatening, offensive,
+or harmful.
+
+Community leaders have the right and responsibility to remove, edit, or reject
+comments, commits, code, wiki edits, issues, and other contributions that are
+not aligned to this Code of Conduct, and will communicate reasons for moderation
+decisions when appropriate.
+
+## Scope
+
+This Code of Conduct applies within all community spaces, and also applies when
+an individual is officially representing the community in public spaces.
+Examples of representing our community include using an official e-mail address,
+posting via an official social media account, or acting as an appointed
+representative at an online or offline event.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported to the community leaders responsible for enforcement at
+[email protected].
+All complaints will be reviewed and investigated promptly and fairly.
+
+All community leaders are obligated to respect the privacy and security of the
+reporter of any incident.
+
+## Enforcement Guidelines
+
+Community leaders will follow these Community Impact Guidelines in determining
+the consequences for any action they deem in violation of this Code of Conduct:
+
+### 1. Correction
+
+**Community Impact**: Use of inappropriate language or other behavior deemed
+unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing
+clarity around the nature of the violation and an explanation of why the
+behavior was inappropriate. A public apology may be requested.
+
+### 2. Warning
+
+**Community Impact**: A violation through a single incident or series
+of actions.
+
+**Consequence**: A warning with consequences for continued behavior. No
+interaction with the people involved, including unsolicited interaction with
+those enforcing the Code of Conduct, for a specified period of time. This
+includes avoiding interactions in community spaces as well as external channels
+like social media. Violating these terms may lead to a temporary or
+permanent ban.
+
+### 3. Temporary Ban
+
+**Community Impact**: A serious violation of community standards, including
+sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public
+communication with the community for a specified period of time. No public or
+private interaction with the people involved, including unsolicited interaction
+with those enforcing the Code of Conduct, is allowed during this period.
+Violating these terms may lead to a permanent ban.
+
+### 4. Permanent Ban
+
+**Community Impact**: Demonstrating a pattern of violation of community
+standards, including sustained inappropriate behavior,  harassment of an
+individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within
+the community.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage],
+version 2.0, available at
+https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
+
+Community Impact Guidelines were inspired by [Mozilla's code of conduct
+enforcement ladder](https://github.com/mozilla/diversity).
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see the FAQ at
+https://www.contributor-covenant.org/faq. Translations are available at
+https://www.contributor-covenant.org/translations.

CONTRIBUTING.md

@@ -0,0 +1,53 @@
+# How to Contribute
+## Contribute to Development
+Welcome! We are glad that you want to contribute to our project! 🚀
+
+Below you can find some options
+
+### Answer Questions on the Community Forum
+Our [Community Forum](https://forum.opennebula.io) is the place to ask questions and help them to solve. If you are interested in contribute and have knowledge about virtualization, cloud, automation, etc. You can help us by answering questions from other users. Create an account if you don't have one, and start checking the forum.
+
+### Bug Reporting
+You can report a bug by opening a new issue [here](https://github.com/OpenNebula/one/issues/new?template=bug_report.md). Please, make sure that you follow the template for bug reports and all sections have been completed:
+* Version of OpenNebula
+* Component
+* Brief description
+* Expected behavior
+* How to reproduce
+
+You can find more information on our Wiki page: [How to Report Bugs](https://github.com/OpenNebula/one/wiki/How-to-Report-Bugs-and-Make-Feature-Requests)
+
+### Feature Request
+You can request a new feature by opening an issue [here](https://github.com/OpenNebula/one/issues/new?template=enhancement-request.md). Please, make sure that you follow the template for new features and all sections have been completed:
+
+* Brief description of the new functionality
+* How are you going to use this new feature? Why do you need it?
+* Describe any changes to current interfaces including Sunstone, CLI and/or API
+
+More information can be found on the wiki: [Feature Request](https://github.com/OpenNebula/one/wiki/How-to-Report-Bugs-and-Make-Feature-Requests#how-do-i-submit-a-new-feature-request)
+
+### Contribute to Addons Development
+You can participate by developing a new addon, or contributing to the existing addons we have on [our marketplace](https://github.com/OpenNebula/one/wiki/Add_ons-Catalog). Please check our [guidelines and recommendations](https://github.com/OpenNebula/one/wiki/How-to-participate-in-Add_on-Development) on the wiki page.
+
+We strongly suggest to use the [Community Forum](https://forum.opennebula.io) in order to ask for help, or to make your addon official.
+
+### Quality Assurance
+QA & Testing of a cloud management tool is particularly challenging as it requires validating the integration of multiple software components, from different hypervisors and storage architectures to operating systems and DB backends.
+
+As part of OpenNebula QA we perform the following activities:
+
+* Development and maintenance of a testing framework to exercise all the OpenNebula components
+* Maintenance of a testing infrastructure with multiple hypervisors and storage configurations
+* Regular test execution and circling feedback through to the development process by filing issues
+* Manage up-to-date set of test cases for wide functionality scenario coverage.
+* Automation of testing and bug identification process
+
+You can find how to help us on the [Quality Assurance Page](https://github.com/OpenNebula/one/wiki/Quality-Assurance)
+
+### Localization
+We welcome contributions also to translate our platform to different languages. We use Transifex to localize the project, so you'll need to create an account (if you don't have one), or use your existing Transifex credential. Please check the status of the locale on the [OpenNebula Transifex page](https://explore.transifex.com/opennebula/one/)
+
+### Report a Vulnerability
+The OpenNebula Vulnerability Management Team (VMT) is responsible for coordinating the process of evaluating, fixing and disclosing those security vulnerabilities reported by members of the OpenNebula Community. Members of the VMT are all part of the Engineering Team at [OpenNebula Systems](https://opennebula.io), the company that manages and coordinates the development of the OpenNebula project. Membership of this team is intentionally limited to a small number of people.
+
+Please check our Wiki to know more about how to [Report a Security Vulnerability](https://github.com/OpenNebula/one/wiki/Vulnerability-Management-Process)