M #-: Various oneprovison/ansible updates (#3202)

- allow newer ansible in provision
 - remove unsused files, roles
 - simplify opennebula-node-kvm
 - remove unsued ceonts files,
 - rename yaml -> yml
 - replace `include:` with `include_tasks:`
 - don't restart frr
 - bump Ceph version in HCI to Reef, adopt ceph-opennebula-mon

share/oneprovision/ansible/ansible.cfg.erb

@@ -4,12 +4,12 @@ deprecation_warnings  = False
 display_skipped_hosts = False
 stdout_callback       = yaml
 host_key_checking     = False
-roles_path            = <%= ans_loc %>/roles:/var/lib/one/.ansible/roles:/var/lib/one/.ansible/ceph-7.0/roles
-action_plugins        = /var/lib/one/.ansible/ceph-7.0/plugins/actions
-callback_plugins      = /var/lib/one/.ansible/ceph-7.0/plugins/callback
-filter_plugins        = /var/lib/one/.ansible/ceph-7.0/plugins/filter
-library               = /var/lib/one/.ansible/ceph-7.0/library
-module_utils          = /var/lib/one/.ansible/ceph-7.0/module_utils
+roles_path            = <%= ans_loc %>/roles:/var/lib/one/.ansible/roles:/var/lib/one/.ansible/ceph-8.0/roles
+action_plugins        = /var/lib/one/.ansible/ceph-8.0/plugins/actions
+callback_plugins      = /var/lib/one/.ansible/ceph-8.0/plugins/callback
+filter_plugins        = /var/lib/one/.ansible/ceph-8.0/plugins/filter
+library               = /var/lib/one/.ansible/ceph-8.0/library
+module_utils          = /var/lib/one/.ansible/ceph-8.0/module_utils
 
 [privilege_escalation]
 become = yes

share/oneprovision/ansible/ceph_hci/group_vars.yml.erb

@@ -1,16 +1,12 @@
 ---
 # Ceph basics
 ceph_origin: repository
-ceph_repository: uca
+ceph_repository: community
 ceph_rhcs_version: 7
-ceph_stable_release: quincy
-ceph_stable_release_num: 17
+ceph_stable_release: reef
+ceph_stable_release_num: 18
 dashboard_enabled: false
 configure_firewall: false
-ceph_stable_mapping:
-  '20': yoga
-  '22': bobcat
-ceph_stable_openstack_release_uca: "{{ ceph_stable_mapping[ansible_distribution_major_version] }}"
 
 # ceph overrides (applying in ceph.conf)
 ceph_conf_overrides:

share/oneprovision/ansible/roles/ceph-opennebula-mon/tasks/auth.yml

@@ -1,13 +1,12 @@
 ---
-- name: Set Ceph auth command init
-  set_fact: ceph_opennebula_mon_pools_auth=[]
+- name: Create oneadmin keys
+  vars:
+    _profiles_with_pools: >-
+      {{ ceph_opennebula_mon_pools | map(attribute='name')
+                                   | map('regex_replace', '^', 'profile rbd pool=')
+                                   | join(',') }}
 
-- name: Set Ceph auth command pools
-  set_fact: ceph_opennebula_mon_pools_auth="{{ ceph_opennebula_mon_pools_auth }} + [ 'profile rbd pool={{ item.name }}' ]"
-  with_items: "{{ ceph_opennebula_mon_pools }}"
-
-- name: Create oneadmin keys for Ceph Luminous+
-  command: ceph auth get-or-create client.oneadmin mon 'profile rbd' osd '{{ ceph_opennebula_mon_pools_auth | join(",") }}'
+  command: ceph auth get-or-create client.oneadmin mon 'profile rbd' osd '{{ _profiles_with_pools }}'
   changed_when: false
 
 - name: get oneadmin key

share/oneprovision/ansible/roles/ceph-opennebula-mon/tasks/main.yml

@@ -2,8 +2,8 @@
 - name: open /etc/ceph
   file: path=/etc/ceph mode=0755
 
-- include: pool.yml
+- include_tasks: pool.yml
 
-- include: auth.yml
+- include_tasks: auth.yml
 
-- include: tunables.yml
+- include_tasks: tunables.yml

share/oneprovision/ansible/roles/ceph-opennebula-osd/tasks/main.yml

@@ -25,7 +25,7 @@
 
 # configure libvirt secretes
 - name: Include libvirt configuration tasks
-  include: libvirt.yml
+  include_tasks: libvirt.yml
   when: ceph_opennebula_osd_libvirt_enabled
 
 # stop and disable docker on hypervisors

share/oneprovision/ansible/roles/ddc/tasks/main.yml

@@ -13,5 +13,3 @@
     masked: yes
     state: stopped
   ignore_errors: yes
-
-- include: clean_netconfigs.yml

share/oneprovision/ansible/roles/frr/handlers/main.yml

@@ -0,0 +1,4 @@
+- name: restart frr
+  service:
+    name: frr
+    state: restarted

share/oneprovision/ansible/roles/frr/tasks/main.yml

@@ -56,6 +56,7 @@
   template:
     src: bgpd_rr.conf.j2
     dest: /etc/frr/bgpd.conf
+  notify: restart frr
   when:
   - vars['ansible_' + frr_iface].ipv4.address is defined
   - vars['ansible_' + frr_iface].ipv4.address in rr_servers
@@ -64,6 +65,7 @@
   template:
     src: bgpd.conf.j2
     dest: /etc/frr/bgpd.conf
+  notify: restart frr
   when:
   - vars['ansible_' + frr_iface].ipv4.address is defined
   - not vars['ansible_' + frr_iface].ipv4.address in rr_servers
@@ -72,27 +74,31 @@
   template:
     src: zebra.conf.j2
     dest: /etc/frr/zebra.conf
+  notify: restart frr
   when: frr_zebra == true
 
 - name: Configure Staticd
   template:
     src: staticd.conf.j2
     dest: /etc/frr/staticd.conf
+  notify: restart frr
   when: frr_zebra == true
 
 - name: Remove frr.conf
   file:
     path: /etc/frr/frr.conf
     state: absent
+  notify: restart frr
 
 - name: Enable BGP daemon
   replace:
     path: /etc/frr/daemons
     regexp: '^bgpd=no'
     replace: 'bgpd=yes'
+  notify: restart frr
 
 - name: Start FRR service
   service:
     name: frr
-    state: restarted
+    state: started
     enabled: yes

share/oneprovision/ansible/roles/iptables/tasks/main.yml

@@ -9,10 +9,8 @@
     reload: yes
 
 - block:
-  - include: redhat.yml
-    when: ansible_os_family == "RedHat"
-  - include: debian.yml
+  - include_tasks: debian.yml
     when: ansible_os_family == "Debian"
   when: iptables_manage_persistent
 
-- include: rules.yml
+- include_tasks: rules.yml

share/oneprovision/ansible/roles/opennebula-node-kvm/defaults/main.yaml → share/oneprovision/ansible/roles/opennebula-node-kvm/defaults/main.yml

@@ -2,16 +2,8 @@
 ###############################################################################
 # Valid defaults
 ###############################################################################
-
-# Whether to use the ev package for kvm
-opennebula_node_kvm_use_ev: False
-
 # Enable nested KVM virtualization
 opennebula_node_kvm_param_nested: False
 
 # Enable KVM configuration
 opennebula_node_kvm_manage_kvm: True
-
-# SELinux booleans to configure
-opennebula_node_selinux_booleans:
-  - { name: 'virt_use_nfs', state: 'yes' }