F #79: Harbor code + persistency #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
rsmontero
reviewed
Apr 25, 2024
appliances/Harbor/appliance.sh
Outdated
| fi | ||
|
|
||
| # Check if /dev/vda exists | ||
| if [ -e "/dev/vda" ]; then |
There was a problem hiding this comment.
We'll probably need a better way of getting the device, maybe a USER INPUT? so vda will depend on the driver used (e.g. sd vs vd) and the number of disks in the VM template. So probably the safest thing is to let the user input which device should be used for persistent data
rsmontero
reviewed
Apr 25, 2024
appliances/Harbor/appliance.sh
Outdated
| msg info "/dev/vda is already mounted." | ||
| else | ||
| # Add entry to /etc/fstab for persistence | ||
| echo "/dev/vda /data ext4 defaults 0 2" | sudo tee -a /etc/fstab > /dev/null |
There was a problem hiding this comment.
why ext4? The volume can be xfs, we may get this from the VM template but maybe it is not there so we may need to use a blkinfo or similar
Signed-off-by: Daniel <[email protected]>
sk4zuzu
reviewed
Apr 26, 2024
sk4zuzu
reviewed
Apr 26, 2024
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
sk4zuzu
reviewed
Apr 30, 2024
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
Signed-off-by: Daniel <[email protected]>
sk4zuzu
reviewed
May 10, 2024
Signed-off-by: Daniel <[email protected]>
sk4zuzu
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.