Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KeyValueStore non-optional to avoid intermittent failure on load #30

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

deejgregor
Copy link
Contributor

We've seen multiple instances at one installation where this is happening
intermittently on startup:

...
Caused by: org.osgi.service.blueprint.container.ServiceUnavailableException: No matching service for optional OSGi service reference: (objectClass=org.opennms.integration.api.v1.distributed.KeyValueStore)
at org.apache.aries.blueprint.container.ReferenceRecipe.getService(ReferenceRecipe.java:272) ~[?:?]
at org.apache.aries.blueprint.container.ReferenceRecipe.access$000(ReferenceRecipe.java:57) ~[?:?]
at org.apache.aries.blueprint.container.ReferenceRecipe$ServiceDispatcher.call(ReferenceRecipe.java:341) ~[?:?]
at Proxy2eb34fe8_fa63_41d0_96b1_a2e6f7cd7d24.enumerateContextAsync(Unknown Source) ~[?:?]
at org.opennms.timeseries.cortex.CortexTSS.(CortexTSS.java:180) ~[?:?]
...

We've seen multiple instances at one installation where this is happening
intermittently on startup:

...
Caused by: org.osgi.service.blueprint.container.ServiceUnavailableException: No matching service for optional OSGi service reference: (objectClass=org.opennms.integration.api.v1.distributed.KeyValueStore)
        at org.apache.aries.blueprint.container.ReferenceRecipe.getService(ReferenceRecipe.java:272) ~[?:?]
        at org.apache.aries.blueprint.container.ReferenceRecipe.access$000(ReferenceRecipe.java:57) ~[?:?]
        at org.apache.aries.blueprint.container.ReferenceRecipe$ServiceDispatcher.call(ReferenceRecipe.java:341) ~[?:?]
        at Proxy2eb34fe8_fa63_41d0_96b1_a2e6f7cd7d24.enumerateContextAsync(Unknown Source) ~[?:?]
        at org.opennms.timeseries.cortex.CortexTSS.<init>(CortexTSS.java:180) ~[?:?]
...
@RangerRick RangerRick force-pushed the deejgregor/keyvaluestore-non-optional branch from 26f42a1 to 2e1d3c3 Compare February 15, 2024 16:17
@RangerRick RangerRick changed the base branch from master to release-2.x February 15, 2024 21:20
@RangerRick RangerRick merged commit 30b0629 into release-2.x Feb 15, 2024
4 checks passed
@cgorantla
Copy link
Contributor

@RangerRick that's good find. I didn't know that we can define capabilities in features!

@RangerRick
Copy link
Contributor

@RangerRick that's good find. I didn't know that we can define capabilities in features!

@cgorantla I found it by accident a while ago when trying to fix validation in my "fix everything karaf related" branches. This is what happens when you start digging into Karaf's source, lol.

@RangerRick RangerRick deleted the deejgregor/keyvaluestore-non-optional branch February 15, 2024 21:47
indigo423 added a commit to indigo423/opennms-cortex-tss-plugin that referenced this pull request Nov 18, 2024
indigo423 added a commit to indigo423/opennms-cortex-tss-plugin that referenced this pull request Dec 15, 2024
indigo423 added a commit to indigo423/opennms-cortex-tss-plugin that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants