Skip to content

Commit

Permalink
Merge pull request #8216 from OpenMined/fix-notemetadajson
Browse files Browse the repository at this point in the history
skip raising Exception on bump version if no staged changes
  • Loading branch information
rasswanth-s authored Nov 2, 2023
2 parents 2c5b88e + 92ca647 commit e3617c8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/syft/src/syft/protocol/data_protocol.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,9 @@ def bump_protocol_version(self) -> Result[SyftSuccess, SyftError]:

keys = self.protocol_history.keys()
if "dev" not in keys:
raise Exception(
"You can't bump the protocol if there are no staged changes."
print("You can't bump the protocol if there are no staged changes.")
return SyftError(
message="Failed to bump version as there are no staged changes."
)

highest_protocol = 0
Expand Down
2 changes: 2 additions & 0 deletions packages/syft/src/syft/service/metadata/node_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ class NodeMetadataJSON(BaseModel, StorableObjectType):
node_type: str = NodeType.DOMAIN.value
organization: str = "OpenMined"
description: str = "My cool domain"
signup_enabled: Optional[bool]
admin_email: Optional[str]
node_side_type: str
show_warnings: bool
supported_protocols: List = []
Expand Down

0 comments on commit e3617c8

Please sign in to comment.