skip raising Exception on bump version if no staged changes

make signup and admin email fields Optional
OpenMined · Nov 1, 2023 · e228e27 · e228e27
1 parent 29e45bd
commit e228e27
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/syft/src/syft/protocol/data_protocol.py b/packages/syft/src/syft/protocol/data_protocol.py
@@ -271,8 +271,9 @@ def bump_protocol_version(self) -> Result[SyftSuccess, SyftError]:
 
         keys = self.protocol_history.keys()
         if "dev" not in keys:
-            raise Exception(
-                "You can't bump the protocol if there are no staged changes."
+            print("You can't bump the protocol if there are no staged changes.")
+            return SyftError(
+                message="Failed to bump version as there are no staged changes."
             )
 
         highest_protocol = 0

diff --git a/packages/syft/src/syft/service/metadata/node_metadata.py b/packages/syft/src/syft/service/metadata/node_metadata.py
@@ -134,8 +134,8 @@ class NodeMetadataJSON(BaseModel, StorableObjectType):
     organization: str = "OpenMined"
     on_board: bool = False
     description: str = "My cool domain"
-    signup_enabled: bool
-    admin_email: str
+    signup_enabled: Optional[bool]
+    admin_email: Optional[str]
     node_side_type: str
     show_warnings: bool
     supported_protocols: List = []