Add pre_thresholding to Beam PrivatePCollection API #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvadym
changed the title
monsieurmuffin
approved these changes
May 17, 2024
| @@ -32,6 +32,8 @@ | |||
| FLAGS = flags.FLAGS | |||
| flags.DEFINE_string('input_file', None, 'The file with the movie view data') | |||
| flags.DEFINE_string('output_file', None, 'Output file') | |||
| flags.DEFINE_integer('pre_threshold', None, | |||
| 'Pre threshold which is used in the DP aggregation') | |||
There was a problem hiding this comment.
nit: it might be worth mentioning to which aggregations pre-threshold is currently applied.
| # The value we're aggregating: we're summing up ratings | ||
| value_extractor=lambda mv: mv.rating) | ||
| if FLAGS.pre_threshold: | ||
| params.pre_threshold = FLAGS.pre_threshold |
There was a problem hiding this comment.
I would have a preference for defining it at the same level as the other parameters rather than as a flag, because it's not very clear why we specify parameters in different places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.