Changed getOpenMageVersion()
#4496
Draft
+48
−627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Template : admin
|
Hanmac
reviewed
Jan 21, 2025
Comment on lines
+185
to
+187
| $versionfromGit = self::getVersionFromGit($withHas); | ||
| if ($versionfromGit) { | ||
| return $versionfromGit; |
There was a problem hiding this comment.
Wouldn't that collide with other repos that uses openMage?
if my repo has tags, then it would return my Repo tags instead of the OpenMage tags
There was a problem hiding this comment.
Missed to push last commits. Check for composer version has to come first.
Will update PR tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests work.
We dont need to upgrade the verion for every release anymore, but 3rd-party cant get the version info anymore.
In a composer-based procet you can detect the installed version easily. Do we need to have hardcoded version number?